| Message ID | 1564407819-10746-4-git-send-email-saranya.gopal@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: dwc3: Prevent requests from being queued twice | expand |
On Mon, Jul 29, 2019 at 07:13:39PM +0530, Saranya Gopal wrote: > From: Felipe Balbi <felipe.balbi@linux.intel.com> > > [Upstream commit 7c3d7dc89e57a1d43acea935882dd8713c9e639f] > > Now that we have req->status, we don't need this extra flag > anymore. It's safe to remove it. > > Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> > Signed-off-by: Saranya Gopal <saranya.gopal@intel.com> > --- > drivers/usb/dwc3/core.h | 2 -- > drivers/usb/dwc3/gadget.c | 1 - > drivers/usb/dwc3/gadget.h | 2 -- > 3 files changed, 5 deletions(-) Why is this patch needed for a stable tree? It just cleans stuff up, it doesn't actually change any functionality. thanks, greg k-h
> > > > [Upstream commit 7c3d7dc89e57a1d43acea935882dd8713c9e639f] > > > > Now that we have req->status, we don't need this extra flag > > anymore. It's safe to remove it. > > > > Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> > > Signed-off-by: Saranya Gopal <saranya.gopal@intel.com> > > --- > > drivers/usb/dwc3/core.h | 2 -- > > drivers/usb/dwc3/gadget.c | 1 - > > drivers/usb/dwc3/gadget.h | 2 -- > > 3 files changed, 5 deletions(-) > > Why is this patch needed for a stable tree? It just cleans stuff up, it > doesn't actually change any functionality. Yes, this can be skipped. Thanks, Saranya
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 301bf94..6ea3e48 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -852,7 +852,6 @@ struct dwc3_hwparams { * or unaligned OUT) * @direction: IN or OUT direction flag * @mapped: true when request has been dma-mapped - * @started: request is started */ struct dwc3_request { struct usb_request request; @@ -881,7 +880,6 @@ struct dwc3_request { unsigned needs_extra_trb:1; unsigned direction:1; unsigned mapped:1; - unsigned started:1; }; /* diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index a56a92a..f29068d 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -174,7 +174,6 @@ static void dwc3_gadget_del_and_unmap_request(struct dwc3_ep *dep, { struct dwc3 *dwc = dep->dwc; - req->started = false; list_del(&req->list); req->remaining = 0; req->needs_extra_trb = false; diff --git a/drivers/usb/dwc3/gadget.h b/drivers/usb/dwc3/gadget.h index 6aebe8c..3ed738e 100644 --- a/drivers/usb/dwc3/gadget.h +++ b/drivers/usb/dwc3/gadget.h @@ -75,7 +75,6 @@ static inline void dwc3_gadget_move_started_request(struct dwc3_request *req) { struct dwc3_ep *dep = req->dep; - req->started = true; req->status = DWC3_REQUEST_STATUS_STARTED; list_move_tail(&req->list, &dep->started_list); } @@ -91,7 +90,6 @@ static inline void dwc3_gadget_move_cancelled_request(struct dwc3_request *req) { struct dwc3_ep *dep = req->dep; - req->started = false; req->status = DWC3_REQUEST_STATUS_CANCELLED; list_move_tail(&req->list, &dep->cancelled_list); }