| Message ID | 1588888768-25315-4-git-send-email-wcheng@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Re-introduce TX FIFO resize for larger EP bursting | expand |
On Thu, May 07, 2020 at 02:59:28PM -0700, Wesley Cheng wrote: > Re-introduce the comment for the tx-fifo-resize setting for the DWC3 > controller. Why? > > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > index 9946ff9..489f5da 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -105,7 +105,7 @@ Optional properties: > 1-16 (DWC_usb31 programming guide section 1.2.3) to > enable periodic ESS TX threshold. > > - - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated. > + - tx-fifo-resize: determines if the FIFO *has* to be reallocated. > - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0 > register, undefined length INCR burst type enable and INCRx type. > When just one value, which means INCRX burst mode enabled. When > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project
On 5/14/2020 8:10 PM, Rob Herring wrote: > On Thu, May 07, 2020 at 02:59:28PM -0700, Wesley Cheng wrote: >> Re-introduce the comment for the tx-fifo-resize setting for the DWC3 >> controller. > > Why? > Hi Rob, Initially, the reasoning behind bringing back the DTSI parameter, was to address situations where vendors don't require the resizing logic. I was assuming that each vendor has their own HW configuration for the TX FIFO size, and some may already have sufficient space to account for their endpoint requirements. However, if Felipe doesn't believe we need to have a DTSI parameter for this, then we don't need to re-add this back in. >> >> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> >> --- >> Documentation/devicetree/bindings/usb/dwc3.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt >> index 9946ff9..489f5da 100644 >> --- a/Documentation/devicetree/bindings/usb/dwc3.txt >> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt >> @@ -105,7 +105,7 @@ Optional properties: >> 1-16 (DWC_usb31 programming guide section 1.2.3) to >> enable periodic ESS TX threshold. >> >> - - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated. >> + - tx-fifo-resize: determines if the FIFO *has* to be reallocated. >> - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0 >> register, undefined length INCR burst type enable and INCRx type. >> When just one value, which means INCRX burst mode enabled. When >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> a Linux Foundation Collaborative Project
diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt index 9946ff9..489f5da 100644 --- a/Documentation/devicetree/bindings/usb/dwc3.txt +++ b/Documentation/devicetree/bindings/usb/dwc3.txt @@ -105,7 +105,7 @@ Optional properties: 1-16 (DWC_usb31 programming guide section 1.2.3) to enable periodic ESS TX threshold. - - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated. + - tx-fifo-resize: determines if the FIFO *has* to be reallocated. - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0 register, undefined length INCR burst type enable and INCRx type. When just one value, which means INCRX burst mode enabled. When
Re-introduce the comment for the tx-fifo-resize setting for the DWC3 controller. Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> --- Documentation/devicetree/bindings/usb/dwc3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)