diff mbox series

[08/20] dt-bindings: usb: usb-xhci: Document r8a774e1 support

Message ID 1594919915-5225-9-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State New, archived
Headers show
Series Add support for SATA/PCIe/USB2[3]/VIN/CSI on R8A774E1 | expand

Commit Message

Lad Prabhakar July 16, 2020, 5:18 p.m. UTC 
Document r8a774e1 xhci support. The driver will use the fallback
compatible string "renesas,rcar-gen3-xhci", therefore no driver
change is needed.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
---
 Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring (Arm) July 21, 2020, 3:35 a.m. UTC | #1 
On Thu, 16 Jul 2020 18:18:23 +0100, Lad Prabhakar wrote:
> Document r8a774e1 xhci support. The driver will use the fallback
> compatible string "renesas,rcar-gen3-xhci", therefore no driver
> change is needed.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven Aug. 5, 2020, 8:58 a.m. UTC | #2 
On Thu, Jul 16, 2020 at 7:19 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Document r8a774e1 xhci support. The driver will use the fallback
> compatible string "renesas,rcar-gen3-xhci", therefore no driver
> change is needed.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +

In the mean time, this file has been converted to dt-schema in Rob's
tree: Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml

> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -13,6 +13,7 @@ Required properties:
>      - "renesas,xhci-r8a774a1" for r8a774a1 SoC
>      - "renesas,xhci-r8a774b1" for r8a774b1 SoC
>      - "renesas,xhci-r8a774c0" for r8a774c0 SoC
> +    - "renesas,xhci-r8a774e1" for r8a774e1 SoC
>      - "renesas,xhci-r8a7790" for r8a7790 SoC
>      - "renesas,xhci-r8a7791" for r8a7791 SoC
>      - "renesas,xhci-r8a7793" for r8a7793 SoC

For the logical change:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Prabhakar Aug. 27, 2020, 5:15 p.m. UTC | #3 
Hi Greg,

On Thu, Jul 16, 2020 at 6:19 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> Document r8a774e1 xhci support. The driver will use the fallback
> compatible string "renesas,rcar-gen3-xhci", therefore no driver
> change is needed.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
>  1 file changed, 1 insertion(+)
>
Gentle ping.

Cheers,
Prabhakar
Yoshihiro Shimoda Aug. 28, 2020, 1:11 a.m. UTC | #4 
Hi Lad-san,

> From: Lad, Prabhakar, Sent: Friday, August 28, 2020 2:15 AM
> 
> Hi Greg,
> 
> On Thu, Jul 16, 2020 at 6:19 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> >
> > Document r8a774e1 xhci support. The driver will use the fallback
> > compatible string "renesas,rcar-gen3-xhci", therefore no driver
> > change is needed.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> Gentle ping.

Thank you for the ping. However, since the latest kernel has renesas,usb-xhci.yaml,
would you fix the patch?

Best regards,
Yoshihiro Shimoda
Prabhakar Aug. 28, 2020, 7:52 a.m. UTC | #5 
Hi Shimoda-san

On Fri, Aug 28, 2020 at 2:11 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
>
> Hi Lad-san,
>
> > From: Lad, Prabhakar, Sent: Friday, August 28, 2020 2:15 AM
> >
> > Hi Greg,
> >
> > On Thu, Jul 16, 2020 at 6:19 PM Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > >
> > > Document r8a774e1 xhci support. The driver will use the fallback
> > > compatible string "renesas,rcar-gen3-xhci", therefore no driver
> > > change is needed.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > > ---
> > >  Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > Gentle ping.
>
> Thank you for the ping. However, since the latest kernel has renesas,usb-xhci.yaml,
> would you fix the patch?
>
Thank you for pointing out, I have now posted a v2 [1] now. (I missed
out Geert's comment earlier for this patch)

[1] https://patchwork.kernel.org/patch/11742289/

Cheers,
Prabhakar
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
index b120dd6612a2..df91a0bb1eeb 100644
--- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
@@ -13,6 +13,7 @@  Required properties:
     - "renesas,xhci-r8a774a1" for r8a774a1 SoC
     - "renesas,xhci-r8a774b1" for r8a774b1 SoC
     - "renesas,xhci-r8a774c0" for r8a774c0 SoC
+    - "renesas,xhci-r8a774e1" for r8a774e1 SoC
     - "renesas,xhci-r8a7790" for r8a7790 SoC
     - "renesas,xhci-r8a7791" for r8a7791 SoC
     - "renesas,xhci-r8a7793" for r8a7793 SoC