From patchwork Mon Jul 27 07:14:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunfeng Yun X-Patchwork-Id: 11686399 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CF24F6C1 for ; Mon, 27 Jul 2020 07:17:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B634120792 for ; Mon, 27 Jul 2020 07:17:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="q4OJbjt1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727784AbgG0HRA (ORCPT ); Mon, 27 Jul 2020 03:17:00 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:52175 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727047AbgG0HQp (ORCPT ); Mon, 27 Jul 2020 03:16:45 -0400 X-UUID: 69d17728301a4f0fa7c2c995c1c0a018-20200727 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=IOySdoF/dmmR5ME5Xkb3uJOwAvtUS4UDWtTsJzmoSt8=; b=q4OJbjt1MLYxwuBe+Ssk8MHXyRHATHDvsNnC/fAXHwkRHdjNFi1hicroGvKvrX4OcIti8NsVwYuDj9BdOBX0ZXHOR6r2AofYP4fqErsTgII/r9B8ph4d2V1+h/umDPp5S+IlbtPgU4gzhvI3Rg1iKd+A01ZRZDz7+Wh3FIQkJPU=; X-UUID: 69d17728301a4f0fa7c2c995c1c0a018-20200727 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1383872797; Mon, 27 Jul 2020 15:16:42 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 27 Jul 2020 15:16:39 +0800 Received: from localhost.localdomain (10.17.3.153) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 27 Jul 2020 15:16:39 +0800 From: Chunfeng Yun To: Felipe Balbi , Greg Kroah-Hartman CC: Matthias Brugger , Chunfeng Yun , , , , , Eddie Hung Subject: [PATCH 08/11] usb: mtu3: remove useless member @busy in mtu3_ep struct Date: Mon, 27 Jul 2020 15:14:57 +0800 Message-ID: <1595834101-13094-8-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1595834101-13094-1-git-send-email-chunfeng.yun@mediatek.com> References: <1595834101-13094-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 X-MTK: N Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The member @busy in mtu3_ep struct is unnecessary, so remove it. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3.h | 1 - drivers/usb/mtu3/mtu3_gadget.c | 6 ------ 2 files changed, 7 deletions(-) diff --git a/drivers/usb/mtu3/mtu3.h b/drivers/usb/mtu3/mtu3.h index 9d68f25..8fd83bd 100644 --- a/drivers/usb/mtu3/mtu3.h +++ b/drivers/usb/mtu3/mtu3.h @@ -294,7 +294,6 @@ struct mtu3_ep { int flags; u8 wedged; - u8 busy; }; struct mtu3_request { diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c index 2bc9a95..ef9fcd5 100644 --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -17,7 +17,6 @@ void mtu3_req_complete(struct mtu3_ep *mep, { struct mtu3_request *mreq; struct mtu3 *mtu; - int busy = mep->busy; mreq = to_mtu3_request(req); list_del(&mreq->list); @@ -25,8 +24,6 @@ void mtu3_req_complete(struct mtu3_ep *mep, mreq->request.status = status; mtu = mreq->mtu; - mep->busy = 1; - trace_mtu3_req_complete(mreq); spin_unlock(&mtu->lock); @@ -40,14 +37,12 @@ void mtu3_req_complete(struct mtu3_ep *mep, usb_gadget_giveback_request(&mep->ep, &mreq->request); spin_lock(&mtu->lock); - mep->busy = busy; } static void nuke(struct mtu3_ep *mep, const int status) { struct mtu3_request *mreq = NULL; - mep->busy = 1; if (list_empty(&mep->req_list)) return; @@ -195,7 +190,6 @@ static int mtu3_gadget_ep_enable(struct usb_ep *ep, if (ret) goto error; - mep->busy = 0; mep->wedged = 0; mep->flags |= MTU3_EP_ENABLED; mtu->active_ep++;