| Message ID | 1598000179-28417-1-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d98ef43bfb65b5201e1afe36aaf8c4f9d71b4307 |
| Headers | show |
| Series | usb: gadget: u_serial: clear suspended flag when discnnecting | expand |
Hi, > From: Yoshihiro Shimoda, Sent: Friday, August 21, 2020 5:56 PM > Subject: [PATCH] usb: gadget: u_serial: clear suspended flag when discnnecting I realized the subject had typo. So, I'll resubmit v2 patch soon. Best regards, Yoshihiro Shimoda
diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c index 127ecc2..2caccbb 100644 --- a/drivers/usb/gadget/function/u_serial.c +++ b/drivers/usb/gadget/function/u_serial.c @@ -1391,6 +1391,7 @@ void gserial_disconnect(struct gserial *gser) if (port->port.tty) tty_hangup(port->port.tty); } + port->suspended = false; spin_unlock_irqrestore(&port->port_lock, flags); /* disable endpoints, aborting down any active I/O */
The commit aba3a8d01d62 ("usb: gadget: u_serial: add suspend resume callbacks") set/cleared the suspended flag in USB bus suspend/resume only. But, when a USB cable is disconnected in the suspend, since some controllers will not detect USB bus resume, the suspended flag is not cleared. After that, user cannot send any data. To fix the issue, clears the suspended flag in the gserial_disconnect(). Fixes: aba3a8d01d62 ("usb: gadget: u_serial: add suspend resume callbacks") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Tested-by: Linh Phung <linh.phung.jy@renesas.com> Tested-by: Tam Nguyen <tam.nguyen.xa@renesas.com> --- drivers/usb/gadget/function/u_serial.c | 1 + 1 file changed, 1 insertion(+)