| Message ID | 1598922090-39482-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | thunderbolt: Use kobj_to_dev() instead of container_of() | expand |
Hi, On Tue, Sep 01, 2020 at 09:01:30AM +0800, Tian Tao wrote: > Use kobj_to_dev() instead of container_of() OK, but can you write here why it is better? :) > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > drivers/thunderbolt/domain.c | 2 +- > drivers/thunderbolt/switch.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c > index bba4cbf..7a192b7 100644 > --- a/drivers/thunderbolt/domain.c > +++ b/drivers/thunderbolt/domain.c > @@ -275,7 +275,7 @@ static struct attribute *domain_attrs[] = { > static umode_t domain_attr_is_visible(struct kobject *kobj, > struct attribute *attr, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct tb *tb = container_of(dev, struct tb, dev); > > if (attr == &dev_attr_boot_acl.attr) { > diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c > index a921de9..173ce3b 100644 > --- a/drivers/thunderbolt/switch.c > +++ b/drivers/thunderbolt/switch.c > @@ -1649,7 +1649,7 @@ static struct attribute *switch_attrs[] = { > static umode_t switch_attr_is_visible(struct kobject *kobj, > struct attribute *attr, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct tb_switch *sw = tb_to_switch(dev); > > if (attr == &dev_attr_device.attr) { > -- > 2.7.4
Hi: Doesn't really matter for an individual driver, but it may get coppied to lots more. I consider it's a little tidy up. -----邮件原件----- 发件人: Mika Westerberg [mailto:mika.westerberg@linux.intel.com] 发送时间: 2020年9月1日 15:09 收件人: tiantao (H) <tiantao6@hisilicon.com> 抄送: andreas.noever@gmail.com; michael.jamet@intel.com; YehezkelShB@gmail.com; linux-usb@vger.kernel.org; Linuxarm <linuxarm@huawei.com> 主题: Re: [PATCH] thunderbolt: Use kobj_to_dev() instead of container_of() Hi, On Tue, Sep 01, 2020 at 09:01:30AM +0800, Tian Tao wrote: > Use kobj_to_dev() instead of container_of() OK, but can you write here why it is better? :) > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > drivers/thunderbolt/domain.c | 2 +- > drivers/thunderbolt/switch.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thunderbolt/domain.c > b/drivers/thunderbolt/domain.c index bba4cbf..7a192b7 100644 > --- a/drivers/thunderbolt/domain.c > +++ b/drivers/thunderbolt/domain.c > @@ -275,7 +275,7 @@ static struct attribute *domain_attrs[] = { > static umode_t domain_attr_is_visible(struct kobject *kobj, > struct attribute *attr, int n) { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct tb *tb = container_of(dev, struct tb, dev); > > if (attr == &dev_attr_boot_acl.attr) { diff --git > a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index > a921de9..173ce3b 100644 > --- a/drivers/thunderbolt/switch.c > +++ b/drivers/thunderbolt/switch.c > @@ -1649,7 +1649,7 @@ static struct attribute *switch_attrs[] = { > static umode_t switch_attr_is_visible(struct kobject *kobj, > struct attribute *attr, int n) { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct tb_switch *sw = tb_to_switch(dev); > > if (attr == &dev_attr_device.attr) { > -- > 2.7.4
On Tue, Sep 01, 2020 at 07:37:48AM +0000, tiantao (H) wrote: > Hi: > > Doesn't really matter for an individual driver, but it may get coppied to lots more. > I consider it's a little tidy up. That's fine but please write it down in the commit message as well :)
diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c index bba4cbf..7a192b7 100644 --- a/drivers/thunderbolt/domain.c +++ b/drivers/thunderbolt/domain.c @@ -275,7 +275,7 @@ static struct attribute *domain_attrs[] = { static umode_t domain_attr_is_visible(struct kobject *kobj, struct attribute *attr, int n) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct tb *tb = container_of(dev, struct tb, dev); if (attr == &dev_attr_boot_acl.attr) { diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index a921de9..173ce3b 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -1649,7 +1649,7 @@ static struct attribute *switch_attrs[] = { static umode_t switch_attr_is_visible(struct kobject *kobj, struct attribute *attr, int n) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct tb_switch *sw = tb_to_switch(dev); if (attr == &dev_attr_device.attr) {
Use kobj_to_dev() instead of container_of() Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/thunderbolt/domain.c | 2 +- drivers/thunderbolt/switch.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)