From patchwork Fri Apr 19 11:24:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Petrosyan X-Patchwork-Id: 10909747 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2434717EE for ; Fri, 19 Apr 2019 20:05:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16B641FF83 for ; Fri, 19 Apr 2019 20:05:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B21625223; Fri, 19 Apr 2019 20:05:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9FE461FF83 for ; Fri, 19 Apr 2019 20:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727624AbfDSUF4 (ORCPT ); Fri, 19 Apr 2019 16:05:56 -0400 Received: from dc8-smtprelay2.synopsys.com ([198.182.47.102]:36764 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727440AbfDSUFw (ORCPT ); Fri, 19 Apr 2019 16:05:52 -0400 Received: from mailhost.synopsys.com (badc-mailhost2.synopsys.com [10.192.0.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 2CDD1C0AF5; Fri, 19 Apr 2019 11:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1555673082; bh=c9lSu9gx+b5zcFSf2ezSgxnWlP+0IC8IutC81R4Yeo0=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=PMAz4gdfgEDWHTadb6b6YSQF9iBmKS+F4Fs5quZu9TTNmTZ/wKG5NzixETVK9BsiU krwd/wLSZW63AH4UTV+43/Ozo72eujVoqpSog8WaGCG3TfguSthqnrb/53hmTYsBk7 O4/ZzB63ByfSf6ycGONza2+29xZBMD4fH6I82LSz0bOhQ+kE4EbZEj8Tg0sbC3DbiK ITia0mUyhemKSlgxr0qqKaTu7oNbcyTjLOQA7YFOjsJot+i54YYLvm4VO32nlVykCF lwAEosa4P8N6fEXFe3fITuZxKGvRBg1/923YDP/YIYyg/+olhk5Mq5fHhIzaufxeFe XFkkzEAo+3j1A== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 7BDE6A0067; Fri, 19 Apr 2019 11:24:41 +0000 (UTC) Received: from US01HYBRID2.internal.synopsys.com (10.15.246.24) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 19 Apr 2019 04:24:40 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (10.13.134.195) by mrs.synopsys.com (10.15.246.24) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 19 Apr 2019 04:24:40 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=synopsys.onmicrosoft.com; s=selector1-synopsys-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c9lSu9gx+b5zcFSf2ezSgxnWlP+0IC8IutC81R4Yeo0=; b=Rk+ps6agnIcEZstx3Gx7EDyRUbwdCjAsSkudnF+rIskJu8tWzV4grO417uGQAMlQ5zxjmZkhunnqsNyQ/UKNXPPGv932zMsa1AtGdv/Y6XwOJHW9+fxeGVXyF5ntQ7vkcaxDsy8GcYdxIRjAhQYHmtmW7K2M4K2jeoH1Z2P+E2M= Received: from SN1PR12MB2431.namprd12.prod.outlook.com (52.132.195.146) by SN1PR12MB2383.namprd12.prod.outlook.com (52.132.194.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.14; Fri, 19 Apr 2019 11:24:39 +0000 Received: from SN1PR12MB2431.namprd12.prod.outlook.com ([fe80::5ca6:ee5f:1147:df5a]) by SN1PR12MB2431.namprd12.prod.outlook.com ([fe80::5ca6:ee5f:1147:df5a%4]) with mapi id 15.20.1813.013; Fri, 19 Apr 2019 11:24:39 +0000 From: Artur Petrosyan To: Felipe Balbi , Greg Kroah-Hartman , Minas Harutyunyan , "linux-usb@vger.kernel.org" CC: John Youn , Artur Petrosyan Subject: [PATCH v1 07/14] usb: dwc2: Reset DEVADDR after exiting gadget hibernation. Thread-Topic: [PATCH v1 07/14] usb: dwc2: Reset DEVADDR after exiting gadget hibernation. Thread-Index: AQHU9qJ5n2+J+cmLvEavTwfDwgVrIA== Date: Fri, 19 Apr 2019 11:24:39 +0000 Message-ID: <15df61e95536a74b636f19ec142f27b62bb2f5e5.1555672441.git.arturp@synopsys.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR0802CA0024.eurprd08.prod.outlook.com (2603:10a6:800:aa::34) To SN1PR12MB2431.namprd12.prod.outlook.com (2603:10b6:802:27::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=arturp@synopsys.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [84.53.141.187] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c48e737d-f884-4475-5d82-08d6c4b99bb2 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600141)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:SN1PR12MB2383; x-ms-traffictypediagnostic: SN1PR12MB2383: x-microsoft-antispam-prvs: x-forefront-prvs: 0012E6D357 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(39850400004)(346002)(136003)(366004)(199004)(189003)(110136005)(316002)(2616005)(54906003)(68736007)(99286004)(478600001)(8936002)(2501003)(64756008)(52116002)(73956011)(66946007)(118296001)(66446008)(3846002)(6116002)(66066001)(8676002)(36756003)(14454004)(386003)(186003)(305945005)(2906002)(4326008)(102836004)(6436002)(26005)(486006)(256004)(25786009)(53936002)(14444005)(476003)(71200400001)(71190400001)(6512007)(86362001)(107886003)(5660300002)(97736004)(81156014)(446003)(76176011)(6506007)(7736002)(6486002)(11346002)(66476007)(66556008)(81166006);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR12MB2383;H:SN1PR12MB2431.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: synopsys.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BtCYSjyuov1kJxWlcVTdUpjpnk724MgQ2EnvZ/xYTLZLUvgqLtr200sdLEQQE6ynUCOLbd/U67DRi3LuePHkCzjTu1WWnncK5tky5dxVQSrHfVRPu1KLH1s7bJKn+H0qwsvLB3PPWapaSGEltyUhKwbklPpJ24cyqMDE9J2kWhJpjb00+MBwlmhWMl/sSn6epaXvlEeH0/xukoiY5GGmfqOMD50rP8nauOKIY8WvYsaRSwRfKm2Jq/RGrZAV51/cEBSCa+6ymViRHjzhas7IhQZVFQ41H2ZWLymW3tuILdXr/kQPjIRR2WJoLG82HmsBOV/859ky2rg8jxHo0CPSTFibWfZR8YYbRaySWwRgOfp78Amlx+G2dlnqiLw9eWuyBnYHYfjAf7K+IMBISS2gGyBzm0YWljHBCvcpPeBRQLM= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c48e737d-f884-4475-5d82-08d6c4b99bb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2019 11:24:39.1994 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2383 X-OriginatorOrg: synopsys.com Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initially resetting device address was done in dwc2_hsotg_irq() interrupt handler. However, when core is hibernated USB RESET is not handled in dwc2_hsotg_irq() handler, instead USB RESET interrupt is handled in dwc2_handle_gpwrdn_intr() handler. - Added reset device address to zero when core exits from gadget hibernation. Signed-off-by: Artur Petrosyan Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/gadget.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index dcb0fbb8bc42..8c3e1f1c1b0f 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -5234,6 +5234,10 @@ int dwc2_gadget_exit_hibernation(struct dwc2_hsotg *hsotg, /* Restore GUSBCFG, DCFG and DCTL */ dwc2_writel(hsotg, gr->gusbcfg, GUSBCFG); dwc2_writel(hsotg, dr->dcfg, DCFG); + + /* On USB Reset, reset device address to zero */ + if (reset) + dwc2_clear_bit(hsotg, DCFG, DCFG_DEVADDR_MASK); dwc2_writel(hsotg, dr->dctl, DCTL); /* De-assert Wakeup Logic */