| Message ID | 1647932876-23249-2-git-send-email-quic_c_sanm@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | USB DWC3 host wake up support from system suspend | expand |
Hi Sandeep, On Tue, Mar 22, 2022 at 12:37:52PM +0530, Sandeep Maheswaram wrote: > Add variables in dwc3 structure to check HS phy mode which is > used to configure interrupts and phy poweroff flag to check > the phy status during system resume. > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > --- > drivers/usb/dwc3/core.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index 5c9d467..f11a60c 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -1154,6 +1154,9 @@ struct dwc3 { > > bool phys_ready; > > + unsigned int hs_phy_mode; > + bool phy_power_off; > + > struct ulpi *ulpi; > bool ulpi_ready; > Why adding members in a separate patch? This needs to be squashed with 2/5 patch in the series where these members are used in taking host mode PM decisions. Please fix this. Thanks, Pavan
On 3/22/2022 1:39 PM, Pavan Kondeti wrote: > Hi Sandeep, > > On Tue, Mar 22, 2022 at 12:37:52PM +0530, Sandeep Maheswaram wrote: >> Add variables in dwc3 structure to check HS phy mode which is >> used to configure interrupts and phy poweroff flag to check >> the phy status during system resume. >> >> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> >> --- >> drivers/usb/dwc3/core.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h >> index 5c9d467..f11a60c 100644 >> --- a/drivers/usb/dwc3/core.h >> +++ b/drivers/usb/dwc3/core.h >> @@ -1154,6 +1154,9 @@ struct dwc3 { >> >> bool phys_ready; >> >> + unsigned int hs_phy_mode; >> + bool phy_power_off; >> + >> struct ulpi *ulpi; >> bool ulpi_ready; >> > Why adding members in a separate patch? This needs to be squashed with > 2/5 patch in the series where these members are used in taking host > mode PM decisions. Please fix this. > > Thanks, > Pavan Sure . Will do in next version. Regards Sandeep
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 5c9d467..f11a60c 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -1154,6 +1154,9 @@ struct dwc3 { bool phys_ready; + unsigned int hs_phy_mode; + bool phy_power_off; + struct ulpi *ulpi; bool ulpi_ready;
Add variables in dwc3 structure to check HS phy mode which is used to configure interrupts and phy poweroff flag to check the phy status during system resume. Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> --- drivers/usb/dwc3/core.h | 3 +++ 1 file changed, 3 insertions(+)