From patchwork Wed Aug 31 08:47:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhongling0719@126.com" X-Patchwork-Id: 12960556 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCCEECAAD4 for ; Wed, 31 Aug 2022 08:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230110AbiHaItF (ORCPT ); Wed, 31 Aug 2022 04:49:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiHaItE (ORCPT ); Wed, 31 Aug 2022 04:49:04 -0400 Received: from mail-m965.mail.126.com (mail-m965.mail.126.com [123.126.96.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 37AC1C6FED for ; Wed, 31 Aug 2022 01:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=KyHjyflu6G6jUTskLa 9gYJ5xMoTWpbbJdvJwWlhUlFw=; b=OswrZWEGzEMWX1QqdvjXVtTUE4xxt+nhI9 H9Emg0AOeVkh43IIcAk4ngggJCAULCKLhIu7W5UNx2L7H69H5xPF86USrGzoReva KOfE5xDb+T7fD8KD48BLi850fQlohcW8lYkQFywjWJlkAb6SeYs7eGqQ1MzMgsq2 nLGZqopT4= Received: from localhost.localdomain.localdomain (unknown [112.64.161.44]) by smtp10 (Coremail) with SMTP id NuRpCgDXbu8MIA9jn3MEAg--.25954S2; Wed, 31 Aug 2022 16:47:09 +0800 (CST) From: zenghongling To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com Subject: [PATCH v3] uas: add no-uas quirk for Thinkplus and Hiksemi usb-storage Date: Wed, 31 Aug 2022 16:47:37 +0800 Message-Id: <1661935657-24710-1-git-send-email-zhongling0719@126.com> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: NuRpCgDXbu8MIA9jn3MEAg--.25954S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Zr48JrW7WF17urWfAw17trb_yoW8uF1xpF 98WryfC397GF1SvrnIyr4UCryrtayvkF1kGay7Kw15Zw1rta1jgrnrZr4UWry7Cr13Ww40 vFWqvrWxKFy5G3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0ziZqXtUUUUU= X-Originating-IP: [112.64.161.44] X-CM-SenderInfo: x2kr0wpolqwiqxrzqiyswou0bp/1tbiLQ5u0FpD-YVNAAAAsx Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Thinkplus and Hiksemi is reported to fail to work on several platforms with the following error message: [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled endpoint or incorrect stream ring [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 1b000000 05038000 And when running iozone will disconnect from the USB controller, then after re-connecting the device will be offlined and not working at all. Signed-off-by: zenghongling --- drivers/usb/storage/unusual_uas.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index cdff7dc..ddcdf1a 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -62,6 +62,12 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_IGNORE_UAS), +UNUSUAL_DEV(0x090c, 0x2000, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI * commands in UAS mode. Observed with the 1.28 firmware; are there others? @@ -142,6 +148,12 @@ UNUSUAL_DEV(0x0bc2, 0xab2a, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +UNUSUAL_DEV(0x0bda, 0x9210, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Benjamin Tissoires */ UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, "Initio Corporation", @@ -184,6 +196,12 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, + "Thinkplus", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Hans de Goede */ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, "VIA",