| Message ID | 1662720530-32313-1-git-send-email-zenghongling@kylinos.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/3] uas: add no-uas quirk for Hiksemi usb_disk | expand |
On Fri, Sep 09, 2022 at 06:48:50PM +0800, Hongling Zeng wrote: > The UAS mode of Thinkplus is reported to fail to work on > several platforms with the following error message: > > [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled > endpoint or incorrect stream ring > [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 > 1b000000 05038000 > > Falling back to USB mass storage can solve this problem, so ignore UAS > function of this chip. > > Acked-by: Alan Stern <stern@rowland.harvard.edu> I never sent you an Acked-by: for this patch. In fact, I asked you questions about it which you haven't yet answered. Specifically: How do Windows and Mac OSX work with this drive? Alan Stern > Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn> > --- > Change for v1 > - Change the email real name and the code worng place. > > Change for v2 > -Change spelling error. > > Change for v3 > -Add acked-by > > Change for v4 > -Fix version error > --- > drivers/usb/storage/unusual_uas.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index 8a18d58..156e89c 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -198,6 +198,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_ATA_1X), > > +/* Reported-by: Hongling Zeng <zenghongling@kylinos.cn> */ > +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, > + "Thinkplus", > + "External HDD", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_IGNORE_UAS), > + > /* Reported-by: Hans de Goede <hdegoede@redhat.com> */ > UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, > "VIA", > -- > 2.1.0 >
Sorry , I tested it work well on Win7, not good on Win10. I don't have Mac OSX system. We always work on linux environment. Need I resend the version V5 for patch 3 cancel "acked by" ? Thanks! zhongling0719@126.com From: Alan Stern Date: 2022-09-09 20:15 To: Hongling Zeng CC: gregkh; linux-usb; usb-storage; zhongling0719 Subject: Re: [PATCH v4 3/3] uas: ignore UAS for Thinkplus chips On Fri, Sep 09, 2022 at 06:48:50PM +0800, Hongling Zeng wrote: > The UAS mode of Thinkplus is reported to fail to work on > several platforms with the following error message: > > [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled > endpoint or incorrect stream ring > [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 > 1b000000 05038000 > > Falling back to USB mass storage can solve this problem, so ignore UAS > function of this chip. > > Acked-by: Alan Stern <stern@rowland.harvard.edu> I never sent you an Acked-by: for this patch. In fact, I asked you questions about it which you haven't yet answered. Specifically: How do Windows and Mac OSX work with this drive? Alan Stern > Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn> > --- > Change for v1 > - Change the email real name and the code worng place. > > Change for v2 > -Change spelling error. > > Change for v3 > -Add acked-by > > Change for v4 > -Fix version error > --- > drivers/usb/storage/unusual_uas.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index 8a18d58..156e89c 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -198,6 +198,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_ATA_1X), > > +/* Reported-by: Hongling Zeng <zenghongling@kylinos.cn> */ > +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, > + "Thinkplus", > + "External HDD", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_IGNORE_UAS), > + > /* Reported-by: Hans de Goede <hdegoede@redhat.com> */ > UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, > "VIA", > -- > 2.1.0 >
On Fri, Sep 09, 2022 at 09:22:25PM +0800, zhongling0719@126.com wrote: > Sorry , I tested it work well on Win7, not good on Win10. I would guess that Windows 7 doesn't use UAS but Windows 10 does. It's surprising that these devices can be sold nowadays if they don't work with Windows 10 -- who would buy them? > I don't have Mac OSX system. We always work on linux environment. > Need I resend the version V5 for patch 3 cancel "acked by" ? Greg, do you have an opinion? I don't feel very strongly about this. Alan Stern > Thanks! > > zhongling0719@126.com > > From: Alan Stern > Date: 2022-09-09 20:15 > To: Hongling Zeng > CC: gregkh; linux-usb; usb-storage; zhongling0719 > Subject: Re: [PATCH v4 3/3] uas: ignore UAS for Thinkplus chips > On Fri, Sep 09, 2022 at 06:48:50PM +0800, Hongling Zeng wrote: > > The UAS mode of Thinkplus is reported to fail to work on > > several platforms with the following error message: > > > > [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled > > endpoint or incorrect stream ring > > [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 > > 1b000000 05038000 > > > > Falling back to USB mass storage can solve this problem, so ignore UAS > > function of this chip. > > > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > I never sent you an Acked-by: for this patch. In fact, I asked you > questions about it which you haven't yet answered. > > Specifically: How do Windows and Mac OSX work with this drive? > > Alan Stern > > > Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn> > > --- > > Change for v1 > > - Change the email real name and the code worng place. > > > > Change for v2 > > -Change spelling error. > > > > Change for v3 > > -Add acked-by > > > > Change for v4 > > -Fix version error > > --- > > drivers/usb/storage/unusual_uas.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > > index 8a18d58..156e89c 100644 > > --- a/drivers/usb/storage/unusual_uas.h > > +++ b/drivers/usb/storage/unusual_uas.h > > @@ -198,6 +198,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, > > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > > US_FL_NO_ATA_1X), > > > > +/* Reported-by: Hongling Zeng <zenghongling@kylinos.cn> */ > > +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, > > + "Thinkplus", > > + "External HDD", > > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > > + US_FL_IGNORE_UAS), > > + > > /* Reported-by: Hans de Goede <hdegoede@redhat.com> */ > > UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, > > "VIA", > > -- > > 2.1.0 > >
On Fri, Sep 09, 2022 at 02:19:56PM -0400, stern@rowland.harvard.edu wrote: > On Fri, Sep 09, 2022 at 09:22:25PM +0800, zhongling0719@126.com wrote: > > Sorry , I tested it work well on Win7, not good on Win10. > > I would guess that Windows 7 doesn't use UAS but Windows 10 does. It's > surprising that these devices can be sold nowadays if they don't work > with Windows 10 -- who would buy them? > > > I don't have Mac OSX system. We always work on linux environment. > > Need I resend the version V5 for patch 3 cancel "acked by" ? > > Greg, do you have an opinion? I don't feel very strongly about this. I'm going to drop all of these now as they are not being sent properly despite numerous requests to have them done so :( So yes, if they want to be applied, we need another version. But again, I find it very very hard to believe they do not work properly on Windows 10/11/OSX as well as Windows 10 has been out for a very long time now and no one would accept such poor performance on those devices. thanks, greg k-h
I tested many other PID/VID of thinkplus on linux is ok, Only the(0x17ef, 0x3899) output error messgage of uas in dmesg , not can't work , Later I found it affected the performance,The disk speed is lower than use usb-storage. Win10 's speed is lower than win7. so say not good on win10. >I would guess that Windows 7 doesn't use UAS but Windows 10 does. It's >surprising that these devices can be sold nowadays if they don't work >with Windows 10 -- who would buy them? >But again, I find it very very hard to believe they do not work properly >on Windows 10/11/OSX as well as Windows 10 has been out for a very long >time now and no one would accept such poor performance on those devices. zhongling0719@126.com From: stern@rowland.harvard.edu Date: 2022-09-10 02:19 To: zhongling0719@126.com CC: zenghongling@kylinos.cn; Greg KH; linux-usb@vger.kernel.org; usb-storage@lists.one-eyed-alien.net Subject: Re: Re: [PATCH v4 3/3] uas: ignore UAS for Thinkplus chips On Fri, Sep 09, 2022 at 09:22:25PM +0800, zhongling0719@126.com wrote: > Sorry , I tested it work well on Win7, not good on Win10. I would guess that Windows 7 doesn't use UAS but Windows 10 does. It's surprising that these devices can be sold nowadays if they don't work with Windows 10 -- who would buy them? > I don't have Mac OSX system. We always work on linux environment. > Need I resend the version V5 for patch 3 cancel "acked by" ? Greg, do you have an opinion? I don't feel very strongly about this. Alan Stern > Thanks! > > zhongling0719@126.com > > From: Alan Stern > Date: 2022-09-09 20:15 > To: Hongling Zeng > CC: gregkh; linux-usb; usb-storage; zhongling0719 > Subject: Re: [PATCH v4 3/3] uas: ignore UAS for Thinkplus chips > On Fri, Sep 09, 2022 at 06:48:50PM +0800, Hongling Zeng wrote: > > The UAS mode of Thinkplus is reported to fail to work on > > several platforms with the following error message: > > > > [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled > > endpoint or incorrect stream ring > > [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 > > 1b000000 05038000 > > > > Falling back to USB mass storage can solve this problem, so ignore UAS > > function of this chip. > > > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > I never sent you an Acked-by: for this patch. In fact, I asked you > questions about it which you haven't yet answered. > > Specifically: How do Windows and Mac OSX work with this drive? > > Alan Stern > > > Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn> > > --- > > Change for v1 > > - Change the email real name and the code worng place. > > > > Change for v2 > > -Change spelling error. > > > > Change for v3 > > -Add acked-by > > > > Change for v4 > > -Fix version error > > --- > > drivers/usb/storage/unusual_uas.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > > index 8a18d58..156e89c 100644 > > --- a/drivers/usb/storage/unusual_uas.h > > +++ b/drivers/usb/storage/unusual_uas.h > > @@ -198,6 +198,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, > > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > > US_FL_NO_ATA_1X), > > > > +/* Reported-by: Hongling Zeng <zenghongling@kylinos.cn> */ > > +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, > > + "Thinkplus", > > + "External HDD", > > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > > + US_FL_IGNORE_UAS), > > + > > /* Reported-by: Hans de Goede <hdegoede@redhat.com> */ > > UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, > > "VIA", > > -- > > 2.1.0 > >
diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index 8a18d58..156e89c 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -198,6 +198,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +/* Reported-by: Hongling Zeng <zenghongling@kylinos.cn> */ +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, + "Thinkplus", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Hans de Goede <hdegoede@redhat.com> */ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, "VIA",
The UAS mode of Thinkplus is reported to fail to work on several platforms with the following error message: [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled endpoint or incorrect stream ring [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 1b000000 05038000 Falling back to USB mass storage can solve this problem, so ignore UAS function of this chip. Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn> --- Change for v1 - Change the email real name and the code worng place. Change for v2 -Change spelling error. Change for v3 -Add acked-by Change for v4 -Fix version error --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+)