From patchwork Fri Sep 16 02:02:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 12977949 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14D33C32771 for ; Fri, 16 Sep 2022 02:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbiIPCEX (ORCPT ); Thu, 15 Sep 2022 22:04:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbiIPCEO (ORCPT ); Thu, 15 Sep 2022 22:04:14 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2964A8FD52 for ; Thu, 15 Sep 2022 19:04:01 -0700 (PDT) X-UUID: 10d6408a0f4b48a4a844933aece58b34-20220916 Message-ID: <1663293874836163.12.seg@mailgw> X-GW-Reason: 11109 X-Content-Feature: ica/max.line-size 82 audit/email.address 3 dict/software 1 meta/cnt.alert 1 X-CPASD-INFO: ae43496bf53c4ba481afd2c9399be2ce@qrVuU2FrZJKSVXWvg6Wsblhik5KEgaV zU2lnkpFSuLeMbFJkYl1ZgYFqUWJnX2FZVXp4blJgYGJcWHh4lHKPVGBeYIJUdJOAo59UZGJp X-CLOUD-ID: ae43496bf53c4ba481afd2c9399be2ce X-CPASD-SUMMARY: SIP:-1,APTIP:-2.0,KEY:0.0,FROMBLOCK:1,OB:0.0,URL:-5,TVAL:172. 0,ESV:0.0,ECOM:-5.0,ML:12.0,FD:0.0,CUTS:178.0,IP:-2.0,MAL:-5.0,PHF:-5.0,PHC:- 5.0,SPF:4.0,EDMS:-5,IPLABEL:4480.0,FROMTO:0,AD:0,FFOB:0.0,CFOB:1.0,SPC:0,SIG: -5,AUF:39,DUF:4914,ACD:81,DCD:81,SL:0,EISP:0,AG:0,CFC:0.248,CFSR:0.1,UAT:0,RA F:0,IMG:-5.0,DFA:0,DTA:0,IBL:-2.0,ADI:-5,SBL:0,REDM:0,REIP:0,ESB:0,ATTNUM:0,E AF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 10d6408a0f4b48a4a844933aece58b34-20220916 X-CPASD-BLOCK: 12 X-CPASD-STAGE: 1 X-UUID: 10d6408a0f4b48a4a844933aece58b34-20220916 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1793245111; Fri, 16 Sep 2022 10:02:38 +0800 From: Hongling Zeng To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, Hongling Zeng Subject: [PATCH v7 2/3] usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS Date: Fri, 16 Sep 2022 10:02:26 +0800 X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Hiksemi USB_HDD is reported to fail to work on several platforms with the following error message, then after re-connecting the device will be offlined and not working at all. [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18 inflight: CMD [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00 04 00 00 [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00 00 08 00 These disks have a broken uas implementation, the tag field of the status iu-s is not set properly,so we need to fall-back to usb-storage. Acked-by: Alan Stern Signed-off-by: Hongling Zeng --- Change for v1 - Change the email real name and the code worng place. Change for v2 -Change spelling error. Change for v3 -Add acked-by Change for v4 -Fix version error Change for v5 -change version Change for v6 -Change the git message for patch 3 Change for v7 -Update patch 2 --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index a6bf87a..8a18d58 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -149,6 +149,13 @@ UNUSUAL_DEV(0x0bc2, 0xab2a, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x0bda, 0x9210, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Benjamin Tissoires */ UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, "Initio Corporation",