| Message ID | 1665098469-19008-1-git-send-email-justinpopo6@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MAINTAINERS: Update maintainers for broadcom USB | expand |
On 10/6/2022 4:21 PM, justinpopo6@gmail.com wrote: > From: Justin Chen <justinpopo6@gmail.com> > > Al Cooper is no longer the downstream maintainer for broadcom USB. > I will be taking his place as downstream and as an additional > upstream maintainer. > > Signed-off-by: Justin Chen <justinpopo6@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On Thu, Oct 06, 2022 at 04:21:09PM -0700, justinpopo6@gmail.com wrote: > From: Justin Chen <justinpopo6@gmail.com> > > Al Cooper is no longer the downstream maintainer for broadcom USB. > I will be taking his place as downstream and as an additional > upstream maintainer. What do you mean by "downstream" here? > Signed-off-by: Justin Chen <justinpopo6@gmail.com> I need Al's ack as well. thanks, greg k-h
On Thu, Oct 6, 2022 at 11:26 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Thu, Oct 06, 2022 at 04:21:09PM -0700, justinpopo6@gmail.com wrote: > > From: Justin Chen <justinpopo6@gmail.com> > > > > Al Cooper is no longer the downstream maintainer for broadcom USB. > > I will be taking his place as downstream and as an additional > > upstream maintainer. > > What do you mean by "downstream" here? > Downstream as in internal to Broadcom. Apologies for the confusion. Thanks, Justin > > Signed-off-by: Justin Chen <justinpopo6@gmail.com> > > I need Al's ack as well. > > thanks, > > greg k-h
On Thu, Oct 06, 2022 at 11:46:45PM -0700, Justin Chen wrote: > On Thu, Oct 6, 2022 at 11:26 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Thu, Oct 06, 2022 at 04:21:09PM -0700, justinpopo6@gmail.com wrote: > > > From: Justin Chen <justinpopo6@gmail.com> > > > > > > Al Cooper is no longer the downstream maintainer for broadcom USB. > > > I will be taking his place as downstream and as an additional > > > upstream maintainer. > > > > What do you mean by "downstream" here? > > > Downstream as in internal to Broadcom. Apologies for the confusion. Ok, but then why are these all gmail.com addresses? Why not use your proper work addresses instead so that we can at least validate that the patches are coming from a broadcom.com domain? Also, you should reword the changelog text :) thanks, greg k-h
On Thu, Oct 6, 2022 at 11:59 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Thu, Oct 06, 2022 at 11:46:45PM -0700, Justin Chen wrote: > > On Thu, Oct 6, 2022 at 11:26 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > On Thu, Oct 06, 2022 at 04:21:09PM -0700, justinpopo6@gmail.com wrote: > > > > From: Justin Chen <justinpopo6@gmail.com> > > > > > > > > Al Cooper is no longer the downstream maintainer for broadcom USB. > > > > I will be taking his place as downstream and as an additional > > > > upstream maintainer. > > > > > > What do you mean by "downstream" here? > > > > > Downstream as in internal to Broadcom. Apologies for the confusion. > > Ok, but then why are these all gmail.com addresses? Why not use your > proper work addresses instead so that we can at least validate that the > patches are coming from a broadcom.com domain? > I believe the idea is we can continue to support as maintainers even if we are no longer part of broadcom without having to change emails. I believe Florian should be able to comment more. :) > Also, you should reword the changelog text :) > Will do! Will submit a v2 tomorrow. Thanks, Justin > thanks, > > greg k-h
On Fri, Oct 07, 2022 at 12:19:01AM -0700, Justin Chen wrote: > On Thu, Oct 6, 2022 at 11:59 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Thu, Oct 06, 2022 at 11:46:45PM -0700, Justin Chen wrote: > > > On Thu, Oct 6, 2022 at 11:26 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > > > On Thu, Oct 06, 2022 at 04:21:09PM -0700, justinpopo6@gmail.com wrote: > > > > > From: Justin Chen <justinpopo6@gmail.com> > > > > > > > > > > Al Cooper is no longer the downstream maintainer for broadcom USB. > > > > > I will be taking his place as downstream and as an additional > > > > > upstream maintainer. > > > > > > > > What do you mean by "downstream" here? > > > > > > > Downstream as in internal to Broadcom. Apologies for the confusion. > > > > Ok, but then why are these all gmail.com addresses? Why not use your > > proper work addresses instead so that we can at least validate that the > > patches are coming from a broadcom.com domain? > > > I believe the idea is we can continue to support as maintainers even > if we are no longer part of broadcom without having to change emails. > I believe Florian should be able to comment more. :) So in other words, broadcom email servers do not allow sending patches out without mangling the text? :) thanks, greg k-h
On 10/7/22 00:26, Greg KH wrote: > On Fri, Oct 07, 2022 at 12:19:01AM -0700, Justin Chen wrote: >> On Thu, Oct 6, 2022 at 11:59 PM Greg KH <gregkh@linuxfoundation.org> wrote: >>> >>> On Thu, Oct 06, 2022 at 11:46:45PM -0700, Justin Chen wrote: >>>> On Thu, Oct 6, 2022 at 11:26 PM Greg KH <gregkh@linuxfoundation.org> wrote: >>>>> >>>>> On Thu, Oct 06, 2022 at 04:21:09PM -0700, justinpopo6@gmail.com wrote: >>>>>> From: Justin Chen <justinpopo6@gmail.com> >>>>>> >>>>>> Al Cooper is no longer the downstream maintainer for broadcom USB. >>>>>> I will be taking his place as downstream and as an additional >>>>>> upstream maintainer. >>>>> >>>>> What do you mean by "downstream" here? >>>>> >>>> Downstream as in internal to Broadcom. Apologies for the confusion. >>> >>> Ok, but then why are these all gmail.com addresses? Why not use your >>> proper work addresses instead so that we can at least validate that the >>> patches are coming from a broadcom.com domain? >>> >> I believe the idea is we can continue to support as maintainers even >> if we are no longer part of broadcom without having to change emails. >> I believe Florian should be able to comment more. :) > > So in other words, broadcom email servers do not allow sending patches > out without mangling the text? :) That was definitively the case years ago due to IT using a Microsoft Exchange SMTP server and which had us switch to our gmail.com accounts. The "continuity" aspect of not having your email change does matter IMHO in that we should always be reachable, at expense of not immediately disclosing our employer. Other reasons I heard was that people posting publicly with a @broadcom.com email grew tired of being asked when they would get a working WLAN driver for their card. Now we supposedly have a special SMTP server that would not mangle the patches and also not add the annoying legalese footer at the end telling you to destroy the email. Does it matter though as long as Jonathan Corbet knows about our employer at the time for his lwn.net stats :)? -- Florian
On Fri, Oct 07, 2022 at 11:45:04AM -0700, Florian Fainelli wrote: > On 10/7/22 00:26, Greg KH wrote: > > On Fri, Oct 07, 2022 at 12:19:01AM -0700, Justin Chen wrote: > > > On Thu, Oct 6, 2022 at 11:59 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > > > On Thu, Oct 06, 2022 at 11:46:45PM -0700, Justin Chen wrote: > > > > > On Thu, Oct 6, 2022 at 11:26 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > > > On Thu, Oct 06, 2022 at 04:21:09PM -0700, justinpopo6@gmail.com wrote: > > > > > > > From: Justin Chen <justinpopo6@gmail.com> > > > > > > > > > > > > > > Al Cooper is no longer the downstream maintainer for broadcom USB. > > > > > > > I will be taking his place as downstream and as an additional > > > > > > > upstream maintainer. > > > > > > > > > > > > What do you mean by "downstream" here? > > > > > > > > > > > Downstream as in internal to Broadcom. Apologies for the confusion. > > > > > > > > Ok, but then why are these all gmail.com addresses? Why not use your > > > > proper work addresses instead so that we can at least validate that the > > > > patches are coming from a broadcom.com domain? > > > > > > > I believe the idea is we can continue to support as maintainers even > > > if we are no longer part of broadcom without having to change emails. > > > I believe Florian should be able to comment more. :) > > > > So in other words, broadcom email servers do not allow sending patches > > out without mangling the text? :) > > That was definitively the case years ago due to IT using a Microsoft > Exchange SMTP server and which had us switch to our gmail.com accounts. The > "continuity" aspect of not having your email change does matter IMHO in that > we should always be reachable, at expense of not immediately disclosing our > employer. Other reasons I heard was that people posting publicly with a > @broadcom.com email grew tired of being asked when they would get a working > WLAN driver for their card. > > Now we supposedly have a special SMTP server that would not mangle the > patches and also not add the annoying legalese footer at the end telling you > to destroy the email. > > Does it matter though as long as Jonathan Corbet knows about our employer at > the time for his lwn.net stats :)? It doesn't really matter much, but we are seeing more and more email validation being added and required over time for people sending patches. So it's up to you and your corporate rules as to what you want to do. thanks, greg k-h
diff --git a/MAINTAINERS b/MAINTAINERS index 8656ab7..3e8ecde2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4078,6 +4078,7 @@ N: bcm7038 N: bcm7120 BROADCOM BDC DRIVER +M: Justin Chen <justinpopo6@gmail.com> M: Al Cooper <alcooperx@gmail.com> L: linux-usb@vger.kernel.org R: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> @@ -4184,6 +4185,7 @@ F: Documentation/devicetree/bindings/serial/brcm,bcm7271-uart.yaml F: drivers/tty/serial/8250/8250_bcm7271.c BROADCOM BRCMSTB USB EHCI DRIVER +M: Justin Chen <justinpopo6@gmail.com> M: Al Cooper <alcooperx@gmail.com> R: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> L: linux-usb@vger.kernel.org @@ -4200,6 +4202,7 @@ F: Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yaml F: drivers/usb/misc/brcmstb-usb-pinmap.c BROADCOM BRCMSTB USB2 and USB3 PHY DRIVER +M: Justin Chen <justinpopo6@gmail.com> M: Al Cooper <alcooperx@gmail.com> R: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> L: linux-kernel@vger.kernel.org