| Message ID | 1669707158-43984-1-git-send-email-wangyufen@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4] USB: FHCI: fix error return code in of_fhci_probe() | expand |
On Tue, Nov 29, 2022 at 03:32:38PM +0800, Wang Yufen wrote: > Fix to return a negative error code of PTR_ERR(fhci->gpiods[i]) > instead of 0. > > Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors") > Signed-off-by: Wang Yufen <wangyufen@huawei.com> > Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> > --- > drivers/usb/host/fhci-hcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c > index 95a4446..f84f1c8 100644 > --- a/drivers/usb/host/fhci-hcd.c > +++ b/drivers/usb/host/fhci-hcd.c > @@ -639,8 +639,8 @@ static int of_fhci_probe(struct platform_device *ofdev) > NULL, i, GPIOD_OUT_LOW); > > if (IS_ERR(fhci->gpiods[i])) { > - dev_err(dev, "incorrect GPIO%d: %ld\n", > - i, PTR_ERR(fhci->gpiods[i])); > + ret = PTR_ERR(fhci->gpiods[i]); > + dev_err(dev, "incorrect GPIO%d: %d\n", i, ret); > goto err_gpios; > } > if (!fhci->gpiods[i]) { > -- > 1.8.3.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c index 95a4446..f84f1c8 100644 --- a/drivers/usb/host/fhci-hcd.c +++ b/drivers/usb/host/fhci-hcd.c @@ -639,8 +639,8 @@ static int of_fhci_probe(struct platform_device *ofdev) NULL, i, GPIOD_OUT_LOW); if (IS_ERR(fhci->gpiods[i])) { - dev_err(dev, "incorrect GPIO%d: %ld\n", - i, PTR_ERR(fhci->gpiods[i])); + ret = PTR_ERR(fhci->gpiods[i]); + dev_err(dev, "incorrect GPIO%d: %d\n", i, ret); goto err_gpios; } if (!fhci->gpiods[i]) {
Fix to return a negative error code of PTR_ERR(fhci->gpiods[i]) instead of 0. Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors") Signed-off-by: Wang Yufen <wangyufen@huawei.com> Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> --- drivers/usb/host/fhci-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)