From patchwork Fri Jun 15 22:01:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 10467747 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1BEF5600F4 for ; Fri, 15 Jun 2018 22:02:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B47828EA4 for ; Fri, 15 Jun 2018 22:02:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F3C8428EA6; Fri, 15 Jun 2018 22:02:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A854C28EA4 for ; Fri, 15 Jun 2018 22:02:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756738AbeFOWCK (ORCPT ); Fri, 15 Jun 2018 18:02:10 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:38704 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756684AbeFOWBi (ORCPT ); Fri, 15 Jun 2018 18:01:38 -0400 Received: by mail-pf0-f194.google.com with SMTP id b74-v6so5459443pfl.5; Fri, 15 Jun 2018 15:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QulxF+BM47YvMmSL2bIdB2NPvS8MB137aPcCSSXctqI=; b=ooU8pJ91fSmKf3F4JZUqqy/yQlWkv0s5dGSDgCjggA+q0OSTC8Ya5O2UFpkMU+Zrb2 Ki848kUqaFzMXmwN7lBBeQgOAizh1b4yghDgD006BmjDZHDGs3zcBWajLAe4qPKcEMVJ 1yuAcrXBgAo6UwmS1kh/WnVD/QbFrQWuGb6QudxuxMPWBF/HYa2/g8LtU/rvoADRZigx zHeE89c2zHk+W6zlZT3vopgByTaQtAcVrsxE3rUGEz/hwITAPNgd6E3O97gV2FpMB7kR SKg05iN4Q2Lny1XiJAb12LSTrRHFI0McbbmYcGyItS4YbbYJPKIgkOWqDf03p3nUFJv4 iheA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QulxF+BM47YvMmSL2bIdB2NPvS8MB137aPcCSSXctqI=; b=EPxWsOmx6tkWYkDtSOM2wuiqswcMTPR0sgpJPIMg1fCmlVSdrk3tqBuEXGegHhhbR7 Rm51pxlxGUxOSaaIADWn/TbnjEFonwwTzWUeD+F6IIMWErRq79w53iaHABssfWUwToIs 64fukjg5Kc9QwE/2KTa+zHeFkO20vuQdPXjFiOawr6uVuWlcEXanzoj42eKE5EgLWrjO 7w0ii3VM/Bxm7LxgGDeVeHqakMrtokSVH82nAkxuR5SnB4Mud7spH1VXvgUjO43Wk5mw o4ncqgsFIU/4+eRfj+Ww+U9t/ajR97xhhChMSO823Als6+8j6qqLoFUu9Sb2QKRoQRY9 Kf4g== X-Gm-Message-State: APt69E3alVBrmCI82zqqtFklJWTIdD8PC8XhPJZdkWgl5FSqh3LZ86N2 nZG0nTHI8U6olUWCGkuGsUyQDMLW X-Google-Smtp-Source: ADUXVKIYXI1/ZNyA9c4EyjU1+JSiZTSQ4bZ3DRdR5YjFFk/0fN0T89gsA4APj41WGiIwT4ww/Q1iTg== X-Received: by 2002:a63:77c6:: with SMTP id s189-v6mr3228619pgc.450.1529100097215; Fri, 15 Jun 2018 15:01:37 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:0:1000:1511:8de6:27a8:ed13:2ef5]) by smtp.gmail.com with ESMTPSA id b83-v6sm20233241pfe.159.2018.06.15.15.01.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jun 2018 15:01:36 -0700 (PDT) From: Dmitry Torokhov To: Felipe Balbi , Minas Harutyunyan Cc: Douglas Anderson , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] usb: dwc2: host: do not delay retries after successful transfer Date: Fri, 15 Jun 2018 15:01:30 -0700 Message-Id: <20180615220131.65402-2-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.18.0.rc1.244.gcf134e6275-goog In-Reply-To: <20180615220131.65402-1-dmitry.torokhov@gmail.com> References: <20180615220131.65402-1-dmitry.torokhov@gmail.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When handling split transactions we should not be delaying retrying SSPLIT/CSPLIT after we successfully communicate with the device, so let's reset dtd->num_naks counter when handling XFERCOMPL. Signed-off-by: Dmitry Torokhov Reviewed-by: Douglas Anderson --- drivers/usb/dwc2/hcd_intr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c index d423b6a49f96c..b9879de6230d0 100644 --- a/drivers/usb/dwc2/hcd_intr.c +++ b/drivers/usb/dwc2/hcd_intr.c @@ -1092,6 +1092,7 @@ static void dwc2_hc_xfercomp_intr(struct dwc2_hsotg *hsotg, } handle_xfercomp_done: + qtd->num_naks = 0; disable_hc_int(hsotg, chnum, HCINTMSK_XFERCOMPL); }