diff mbox

Inquiry for adding PID to Cp2102 driver

Message ID 20180618082403.GJ32411@localhost (mailing list archive)
State New, archived
Headers show

Commit Message

Johan Hovold June 18, 2018, 8:24 a.m. UTC 
On Fri, Jun 15, 2018 at 05:05:38PM +0200, Carlos Barcala Lara wrote:
> Dear Johan (and rest of the team)
> 
> This is Carlos Barcala, from CESINEL SL, in Spain. We are a little manufacturer
> of Power Quality Analyzers and Energy Meters. We include in all our products
> the Silabs CP2102 chip for USB communications and we would like to include
> support for our instruments in Linux.
> 
> Somebody gave me your contact regarding this matter, so I beg you to include
> the following items in the Silabs CP2102 Linux kernel´s driver:
> 
> USB\VID_10C4&PID_817C --> "CESINEL MEDCAL N Power Quality Monitor"
> USB\VID_10C4&PID_817D --> "CESINEL MEDCAL NT Power Quality Monitor"
> USB\VID_10C4&PID_817E --> "CESINEL MEDCAL S Power Quality Monitor"
> USB\VID_10C4&PID_82EF --> "CESINEL FALCO 6105 AC Power Supply"
> USB\VID_10C4&PID_82F1 --> "CESINEL MEDCAL EFD Earth Fault Detector"
> USB\VID_10C4&PID_82F2 --> "CESINEL MEDCAL ST Network Analyzer"
> USB\VID_10C4&PID_851E --> "CESINEL MEDCAL PT Network Analyzer"
> USB\VID_10C4&PID_85B8 --> "CESINEL ReCon T Energy Logger"
> USB\VID_10C4&PID_88FB --> "CESINEL MEDCAL STII Network Analyzer"
> USB\VID_10C4&PID_8938 --> "CESINEL MEDCAL S II Network Analyzer"
> USB\VID_10C4&PID_89A4 --> "CESINEL FTBC Flexible Thyristor Bridge Controller"

Would you mind taking a look at the below patch and double check that
I got all the entries right?

If you ever need to add more ids you you could use that patch as a
basis. 

Thanks,
Johan


From c4e9e567fadd76cfe9f70fc9377598a6b7187c38 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Mon, 18 Jun 2018 10:09:44 +0200
Subject: [PATCH] USB: serial: cp210x: add CESINEL device ids

Add device ids for CESINEL products.

Reported-by: Carlos Barcala Lara <cabl@cesinel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/cp210x.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Johan Hovold June 18, 2018, 9:27 a.m. UTC | #1 
On Mon, Jun 18, 2018 at 10:53:35AM +0200, Carlos Barcala Lara wrote:
> Thank you very much, Johan.
> 
> The PIDs are all right.

Thanks for checking.

> I´m sorry, but I don´t know how to use the patch, if needed in the
> future.

It would need to be applied (e.g. using git-am) to the kernel source
tree so that a cp210x driver which includes the new device ids can be
compiled.

I've applied the patch for 4.18-rc with a stable tag so that any kernel
based on the stable trees will soon support your devices as well.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Carlos Barcala Lara June 18, 2018, 9:29 a.m. UTC | #2 
Thanks again, Johan.

Should I have a user to do the git-am (if needed in the future)?

Regards,


El 18/06/2018 a las 11:27, Johan Hovold escribió:
> On Mon, Jun 18, 2018 at 10:53:35AM +0200, Carlos Barcala Lara wrote:
>> Thank you very much, Johan.
>>
>> The PIDs are all right.
> Thanks for checking.
>
>> I´m sorry, but I don´t know how to use the patch, if needed in the
>> future.
> It would need to be applied (e.g. using git-am) to the kernel source
> tree so that a cp210x driver which includes the new device ids can be
> compiled.
>
> I've applied the patch for 4.18-rc with a stable tag so that any kernel
> based on the stable trees will soon support your devices as well.
>
> Thanks,
> Johan

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johan Hovold June 18, 2018, 9:37 a.m. UTC | #3 
On Mon, Jun 18, 2018 at 11:29:51AM +0200, Carlos Barcala Lara wrote:
> Thanks again, Johan.
> 
> Should I have a user to do the git-am (if needed in the future)?

That would only be needed if you ever want to add further device ids.
Then you can create a patch (e.g. by committing you changes to a local
git tree and use git-format-patch), submit it to yourself for testing
purposes (e.g. using git-send-email), and finally apply it using git-am.

The patch submission process is documented in the kernel source tree:

	Documentation/process/submitting-patches.rst

But nothing more is needed for the device ids you reported in this
thread. The mainline and stable tree drivers will soon support them out
of the box.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Felipe Balbi June 18, 2018, 9:40 a.m. UTC | #4 
Johan Hovold <johan@kernel.org> writes:

> On Mon, Jun 18, 2018 at 11:29:51AM +0200, Carlos Barcala Lara wrote:
>> Thanks again, Johan.
>> 
>> Should I have a user to do the git-am (if needed in the future)?
>
> That would only be needed if you ever want to add further device ids.
> Then you can create a patch (e.g. by committing you changes to a local
> git tree and use git-format-patch), submit it to yourself for testing
> purposes (e.g. using git-send-email), and finally apply it using git-am.
>
> The patch submission process is documented in the kernel source tree:
>
> 	Documentation/process/submitting-patches.rst

here's a web version of it:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html
diff mbox

Patch

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 14cf657247b6..ee0cc1d90b51 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -95,6 +95,9 @@  static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(0x10C4, 0x8156) }, /* B&G H3000 link cable */
 	{ USB_DEVICE(0x10C4, 0x815E) }, /* Helicomm IP-Link 1220-DVM */
 	{ USB_DEVICE(0x10C4, 0x815F) }, /* Timewave HamLinkUSB */
+	{ USB_DEVICE(0x10C4, 0x817C) }, /* CESINEL MEDCAL N Power Quality Monitor */
+	{ USB_DEVICE(0x10C4, 0x817D) }, /* CESINEL MEDCAL NT Power Quality Monitor */
+	{ USB_DEVICE(0x10C4, 0x817E) }, /* CESINEL MEDCAL S Power Quality Monitor */
 	{ USB_DEVICE(0x10C4, 0x818B) }, /* AVIT Research USB to TTL */
 	{ USB_DEVICE(0x10C4, 0x819F) }, /* MJS USB Toslink Switcher */
 	{ USB_DEVICE(0x10C4, 0x81A6) }, /* ThinkOptics WavIt */
@@ -112,6 +115,9 @@  static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(0x10C4, 0x826B) }, /* Cygnal Integrated Products, Inc., Fasttrax GPS demonstration module */
 	{ USB_DEVICE(0x10C4, 0x8281) }, /* Nanotec Plug & Drive */
 	{ USB_DEVICE(0x10C4, 0x8293) }, /* Telegesis ETRX2USB */
+	{ USB_DEVICE(0x10C4, 0x82EF) }, /* CESINEL FALCO 6105 AC Power Supply */
+	{ USB_DEVICE(0x10C4, 0x82F1) }, /* CESINEL MEDCAL EFD Earth Fault Detector */
+	{ USB_DEVICE(0x10C4, 0x82F2) }, /* CESINEL MEDCAL ST Network Analyzer */
 	{ USB_DEVICE(0x10C4, 0x82F4) }, /* Starizona MicroTouch */
 	{ USB_DEVICE(0x10C4, 0x82F9) }, /* Procyon AVS */
 	{ USB_DEVICE(0x10C4, 0x8341) }, /* Siemens MC35PU GPRS Modem */
@@ -124,7 +130,9 @@  static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(0x10C4, 0x8470) }, /* Juniper Networks BX Series System Console */
 	{ USB_DEVICE(0x10C4, 0x8477) }, /* Balluff RFID */
 	{ USB_DEVICE(0x10C4, 0x84B6) }, /* Starizona Hyperion */
+	{ USB_DEVICE(0x10C4, 0x851E) }, /* CESINEL MEDCAL PT Network Analyzer */
 	{ USB_DEVICE(0x10C4, 0x85A7) }, /* LifeScan OneTouch Verio IQ */
+	{ USB_DEVICE(0x10C4, 0x85B8) }, /* CESINEL ReCon T Energy Logger */
 	{ USB_DEVICE(0x10C4, 0x85EA) }, /* AC-Services IBUS-IF */
 	{ USB_DEVICE(0x10C4, 0x85EB) }, /* AC-Services CIS-IBUS */
 	{ USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */
@@ -134,10 +142,13 @@  static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(0x10C4, 0x8857) },	/* CEL EM357 ZigBee USB Stick */
 	{ USB_DEVICE(0x10C4, 0x88A4) }, /* MMB Networks ZigBee USB Device */
 	{ USB_DEVICE(0x10C4, 0x88A5) }, /* Planet Innovation Ingeni ZigBee USB Device */
+	{ USB_DEVICE(0x10C4, 0x88FB) }, /* CESINEL MEDCAL STII Network Analyzer */
+	{ USB_DEVICE(0x10C4, 0x8938) }, /* CESINEL MEDCAL S II Network Analyzer */
 	{ USB_DEVICE(0x10C4, 0x8946) }, /* Ketra N1 Wireless Interface */
 	{ USB_DEVICE(0x10C4, 0x8962) }, /* Brim Brothers charging dock */
 	{ USB_DEVICE(0x10C4, 0x8977) },	/* CEL MeshWorks DevKit Device */
 	{ USB_DEVICE(0x10C4, 0x8998) }, /* KCF Technologies PRN */
+	{ USB_DEVICE(0x10C4, 0x89A4) }, /* CESINEL FTBC Flexible Thyristor Bridge Controller */
 	{ USB_DEVICE(0x10C4, 0x8A2A) }, /* HubZ dual ZigBee and Z-Wave dongle */
 	{ USB_DEVICE(0x10C4, 0x8A5E) }, /* CEL EM3588 ZigBee USB Stick Long Range */
 	{ USB_DEVICE(0x10C4, 0x8B34) }, /* Qivicon ZigBee USB Radio Stick */