From patchwork Wed Jun 20 15:20:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 10477699 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4953460532 for ; Wed, 20 Jun 2018 15:20:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3929F28F3A for ; Wed, 20 Jun 2018 15:20:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3784028F3D; Wed, 20 Jun 2018 15:20:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3332028F50 for ; Wed, 20 Jun 2018 15:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754071AbeFTPUM (ORCPT ); Wed, 20 Jun 2018 11:20:12 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:60672 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753853AbeFTPUL (ORCPT ); Wed, 20 Jun 2018 11:20:11 -0400 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1fVetz-0007Tx-NJ; Wed, 20 Jun 2018 17:20:07 +0200 Date: Wed, 20 Jun 2018 17:20:07 +0200 From: Sebastian Andrzej Siewior To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , linux-usb@vger.kernel.org, tglx@linutronix.de, Greg Kroah-Hartman , Alan Stern Subject: [PATCH] USB: note that usb_fill_int_urb() can be used used for ISOC urbs. Message-ID: <20180620152007.xapqkv4ww2hnmvkq@linutronix.de> References: <20180620110105.19955-1-bigeasy@linutronix.de> <3925059.Md1u3KRT1n@avalon> <20180620132144.5cdu2ydlqre4ijg6@linutronix.de> <18211658.4PQ3SEps0f@avalon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <18211658.4PQ3SEps0f@avalon> User-Agent: NeoMutt/20180512 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Laurent suggested that the kerneldoc documentation could state that usb_fill_int_urb() can also be used for the initialisation of an isochronous urb. The USB documentation in Documentation/driver-api/usb/URB.rst already mentions this, some drivers do so and there is no explicit usb_fill_iso_urb(). Suggested-by: Laurent Pinchart Signed-off-by: Sebastian Andrzej Siewior --- On 2018-06-20 17:14:53 [+0300], Laurent Pinchart wrote: > > So you simply asking that the kerneldoc of usb_fill_int_urb() is > > extended to mention isoc, too? > > That would be nice I think. here it is. include/linux/usb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index 4cdd515a4385..c3a8bd586121 100644 --- a/include/linux/usb.h +++ b/include/linux/usb.h @@ -1657,7 +1657,8 @@ static inline void usb_fill_bulk_urb(struct urb *urb, * the endpoint descriptor's bInterval value. * * Initializes a interrupt urb with the proper information needed to submit - * it to a device. + * it to a device. This function can also be used to initialize an isochronous + * urb. * * Note that High Speed and SuperSpeed(+) interrupt endpoints use a logarithmic * encoding of the endpoint interval, and express polling intervals in