| Message ID | 20180704143217.6363-1-miguel@det.uvigo.gal (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
This is another alternative, but it would require exporting usbnet_set_rx_mode. The main drawback of this approach is that it would need to make use that net_device_ops copy in cdc_ncm remains updated, should usbnet.c version change. On the other hand, the structure can be kept const. Which alternative do you think is best? On 04/07/18 16:32, Miguel Rodríguez Pérez wrote: > The cdc_ncm driver overrides the net_device_ops structure used by usbnet > to be able to hook into .ndo_change_mtu. However, the structure was > missing the .ndo_set_rx_mode field, preventing the driver from > hooking into usbnet's set_rx_mode. This patch adds the missing callback to > usbnet_set_rx_mode in net_device_ops. > > Signed-off-by: Miguel Rodríguez Pérez <miguel@det.uvigo.gal> > --- > drivers/net/usb/cdc_ncm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c > index 9e1b74590682..342bf9bb91b5 100644 > --- a/drivers/net/usb/cdc_ncm.c > +++ b/drivers/net/usb/cdc_ncm.c > @@ -755,6 +755,7 @@ static const struct net_device_ops cdc_ncm_netdev_ops = { > .ndo_stop = usbnet_stop, > .ndo_start_xmit = usbnet_start_xmit, > .ndo_tx_timeout = usbnet_tx_timeout, > + .ndo_set_rx_mode = usbnet_set_rx_mode, > .ndo_get_stats64 = usbnet_get_stats64, > .ndo_change_mtu = cdc_ncm_change_mtu, > .ndo_set_mac_address = eth_mac_addr, >
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 9e1b74590682..342bf9bb91b5 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -755,6 +755,7 @@ static const struct net_device_ops cdc_ncm_netdev_ops = { .ndo_stop = usbnet_stop, .ndo_start_xmit = usbnet_start_xmit, .ndo_tx_timeout = usbnet_tx_timeout, + .ndo_set_rx_mode = usbnet_set_rx_mode, .ndo_get_stats64 = usbnet_get_stats64, .ndo_change_mtu = cdc_ncm_change_mtu, .ndo_set_mac_address = eth_mac_addr,
The cdc_ncm driver overrides the net_device_ops structure used by usbnet to be able to hook into .ndo_change_mtu. However, the structure was missing the .ndo_set_rx_mode field, preventing the driver from hooking into usbnet's set_rx_mode. This patch adds the missing callback to usbnet_set_rx_mode in net_device_ops. Signed-off-by: Miguel Rodríguez Pérez <miguel@det.uvigo.gal> --- drivers/net/usb/cdc_ncm.c | 1 + 1 file changed, 1 insertion(+)