From patchwork Fri Jul 6 16:21:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10512097 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 11F1160532 for ; Fri, 6 Jul 2018 16:23:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 036D428722 for ; Fri, 6 Jul 2018 16:23:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EBA5628727; Fri, 6 Jul 2018 16:23:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 992AF28722 for ; Fri, 6 Jul 2018 16:23:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933273AbeGFQXB (ORCPT ); Fri, 6 Jul 2018 12:23:01 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:46660 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933589AbeGFQWT (ORCPT ); Fri, 6 Jul 2018 12:22:19 -0400 Received: by mail-pl0-f65.google.com with SMTP id 30-v6so3099458pld.13 for ; Fri, 06 Jul 2018 09:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=V6tFuVhw9q3NaTlCN0tBQIeSj1osbaNqt87EqArHcp0=; b=gqhJfhOUYitgZ+TYtSuFdwBBuUDXLxDjni2GNbG/LrCzSc7+NvpupdEW6VIBiMln6k 9QtX+3AVT8FpsyMwD3LAxCzJhHIvjuHEcDL23DhdzsF3yZ/E2hgy3/3xEFbYVKXlojao hjo2pQ/1K8XcQBYEjPYd/uM6onYOItIdLXiXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=V6tFuVhw9q3NaTlCN0tBQIeSj1osbaNqt87EqArHcp0=; b=IGTu1mhDUF2mzVF8IJmfiDJCtjGfnrLPfq9tQZ9H6n/PpniquOYz5zlLmsOPa6Qymr hBQ7x8PUEPLBV9tjbRR5qd1VfQ8RmDuDvwZ3IjB03Ys6M/108LiUDMikhhNs1rs7njBc hId6NIXBQ0uGtGm5AiDY+HE8Gyn0KmKxYP/na2GQ6lwNXLVIWnk/goGXgKzFtMp9+UhW iCKNSaE9anQ4rBK1nzd3LIue5e9iQI5PM7GLRVZa8cHaCXcCBYbXpA2Lx/+gFADjf40u AvCIbfh2Nxp4r0j1f9RlDftbNgoJcPgzHVHKgNtD3TeIUcQ/Hxtx4vujzGQ6FhOiulgu Jh3A== X-Gm-Message-State: APt69E3nt47173jTn2Mi2t9+lvlWAJrptFrPHSe4njgXp0Hq5thrhd33 08IUTCbC8bFddJBsi+KwvPs8Yg== X-Google-Smtp-Source: AAOMgpc/BK0cKXOVR1VGfifumkg4fnmJj+iO8sBVoEOd/EEKdIVKBkiFOKp82YU5v27KmxmKuJt7AQ== X-Received: by 2002:a17:902:e281:: with SMTP id cf1-v6mr10943824plb.86.1530894139277; Fri, 06 Jul 2018 09:22:19 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:0:1000:1501:38e4:86fe:ec0c:4007]) by smtp.gmail.com with ESMTPSA id e125-v6sm8926688pfe.52.2018.07.06.09.22.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jul 2018 09:22:18 -0700 (PDT) From: Douglas Anderson To: hminas@synopsys.com, gregkh@linuxfoundation.org Cc: Jerome Brunet , Zhangfei Gao , Stephen Warren , Bruno Herrera , Douglas Anderson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFT PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms Date: Fri, 6 Jul 2018 09:21:52 -0700 Message-Id: <20180706162154.196345-3-dianders@chromium.org> X-Mailer: git-send-email 2.18.0.399.gad0ab374a1-goog In-Reply-To: <20180706162154.196345-1-dianders@chromium.org> References: <20180706162154.196345-1-dianders@chromium.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no reason to have the uframe scheduler off on dwc2. Running with uframe_sched = False is equivalent to saying "I don't want to run the correct code, I want to run the old and incorrect code". The uframe scheduler has been off on HiSilicon since commit 37dd9d65cc41 ("usb: dwc2: add support of hi6220"). Since then there have been many many improvements, notably the commit 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe scheduler") Presumably if everyone is good w/ the uframe_sched turned back on we can kill all the old and crufty non-uframe sched code. Signed-off-by: Douglas Anderson Tested-by: John Stultz --- drivers/usb/dwc2/params.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 14b8742e62fa..db97bb16ecc4 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -67,7 +67,6 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg) p->reload_ctl = false; p->ahbcfg = GAHBCFG_HBSTLEN_INCR16 << GAHBCFG_HBSTLEN_SHIFT; - p->uframe_sched = false; p->change_speed_quirk = true; p->power_down = false; }