From patchwork Fri Jul 6 16:21:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10512089 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6FB99603D7 for ; Fri, 6 Jul 2018 16:22:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6128228722 for ; Fri, 6 Jul 2018 16:22:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 53CDF28727; Fri, 6 Jul 2018 16:22:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA16228722 for ; Fri, 6 Jul 2018 16:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933633AbeGFQWX (ORCPT ); Fri, 6 Jul 2018 12:22:23 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:44944 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933631AbeGFQWV (ORCPT ); Fri, 6 Jul 2018 12:22:21 -0400 Received: by mail-pl0-f68.google.com with SMTP id m16-v6so3104769pls.11 for ; Fri, 06 Jul 2018 09:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lZF1dfoK8II/30Ro89PVWEoJpEsSsWVJI8WlHeVFNj8=; b=Z5bQioAfb4LbEqKvpvKVwcKhSy0lmSEKyk0D/TiFA70Jan6Sxtd2od7K2Cv+nYFbzE uoNXnXgY3AaY6/dQULEA+lq8DKvJquBWZEgwLhmQU8nRjgXdBwMbcmqtKVJyZpBtqsxM CO7b2z0mMDXjrgZUIZcMC5PkZOJFOJ2hKrPAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lZF1dfoK8II/30Ro89PVWEoJpEsSsWVJI8WlHeVFNj8=; b=WrAcsXVcRK1iyQ7zjEcVtgoQhfD93wShNAjMT6P+vwif52hFdeHWnUobWVDCWBa9Su tXZv1uw19Ez4wxOyi/m8laTS7+A4oeT1rCdre7r+JjCm63ez+Dp4VO0WrEftMJSCJdYR mm0ds/qGJGHAQy5nCRZE14Ci989gq8EhD5NHJf98kEyuzNbU25kYJ1xzC0hZwRdxO3hL Yawj0A5DyWVTnlklU3k69euS6672XVTi9d3Dv5rVxJXkzOKsp7zuWjnnVuwjO34a0jsp mvzkkw69QgF10qtnTSrGhZ4tdjHg7J7B89Uxa3sOgkLVu1ZKCMSbS3tonn4h34OY+N5J 5kVQ== X-Gm-Message-State: APt69E3v1Lgx7jkSr7+IpzOtTk89uZuLGQ0grB+ogMDbGuxGKn3Lb11z 7YbgW6fKwz4wEcrjwZbgBHXe4McZERw= X-Google-Smtp-Source: AAOMgpfXX+JtVGwhLuE0zuHZ6zCCqqnneoKsXj4XgLSa25ONEj0/K0uNJHZx/WARqwxG9d/rRHsW4A== X-Received: by 2002:a17:902:8f82:: with SMTP id z2-v6mr10925709plo.203.1530894140628; Fri, 06 Jul 2018 09:22:20 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:0:1000:1501:38e4:86fe:ec0c:4007]) by smtp.gmail.com with ESMTPSA id e125-v6sm8926688pfe.52.2018.07.06.09.22.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jul 2018 09:22:19 -0700 (PDT) From: Douglas Anderson To: hminas@synopsys.com, gregkh@linuxfoundation.org Cc: Jerome Brunet , Zhangfei Gao , Stephen Warren , Bruno Herrera , Douglas Anderson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFT PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms Date: Fri, 6 Jul 2018 09:21:53 -0700 Message-Id: <20180706162154.196345-4-dianders@chromium.org> X-Mailer: git-send-email 2.18.0.399.gad0ab374a1-goog In-Reply-To: <20180706162154.196345-1-dianders@chromium.org> References: <20180706162154.196345-1-dianders@chromium.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no reason to have the uframe scheduler off on dwc2. Running with uframe_sched = False is equivalent to saying "I don't want to run the correct code, I want to run the old and incorrect code". The uframe scheduler has been off on Amlogic since commit f94310ac076e ("usb: dwc2: add support for Meson8b and GXBB SoCs"). While this was after most of the recent improvements, notably the commit 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe scheduler"), presumably the parameters were copied from another platform and the uframe scheduler wasn't tried. Presumably if everyone is good w/ the uframe_sched turned back on we can kill all the old and crufty non-uframe sched code. Signed-off-by: Douglas Anderson --- drivers/usb/dwc2/params.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index db97bb16ecc4..93380f7c32b4 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg) p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI; p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 << GAHBCFG_HBSTLEN_SHIFT; - p->uframe_sched = false; } static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)