From patchwork Fri Jul 6 16:21:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10512091 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2A6DE60532 for ; Fri, 6 Jul 2018 16:22:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C25D28722 for ; Fri, 6 Jul 2018 16:22:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1094528727; Fri, 6 Jul 2018 16:22:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B200328722 for ; Fri, 6 Jul 2018 16:22:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933196AbeGFQWv (ORCPT ); Fri, 6 Jul 2018 12:22:51 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:37936 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933517AbeGFQWW (ORCPT ); Fri, 6 Jul 2018 12:22:22 -0400 Received: by mail-pl0-f66.google.com with SMTP id b1-v6so3105592pls.5 for ; Fri, 06 Jul 2018 09:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/KPLtXATXcbvJucvbamLqM5yqUuoHw6PR+c5raAL6A0=; b=iHgD+fUvi6Nqj5Z+luiuuZtS6DXUH8TsrQW5XNjUo5dtjaPICbuOqm4m/Jdit9MTYD C9eA7mh3aY3M6xq+YgOLGZbAlwWKxVahibZ2cy8c0OM0TGTrukX06p97uTe9BUn8Wzy+ 5F9eY0VhrNIMhNTxIXypjZQkzFS9UAnSFG7SI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/KPLtXATXcbvJucvbamLqM5yqUuoHw6PR+c5raAL6A0=; b=pCOe3EyumCc0PJiH7bDYAIbREkpx3dGHOfDztAYKMPuCBnBntp2P8tWYyAZGVu7kKI JYncRxvSAe/Kbe+U2Ye6Oh3hY7W7r5H/FsvANqVEu8DHGAasI6Y/QtAVYia/xf4Ni64G KbYtFUsSULqg6gnA+noe0D6msRLBy2m0bAgg6mW0Tsq/jJ2Nn5pw504vvicZ2b1VUkb4 89/JlJmzbwLbr1BUrE3oCKTQTkSYJGDhUSa01amq0Zhl4hiDm17HxGnw+hyPVYBk9dVu hbsfjO3O6SfxsmdVjeK1iJsnvXayWkc+NAEwsTELjCkGb9k+/VACIh3iUgRKr5c+IqIN AiFw== X-Gm-Message-State: APt69E2nSbMgCa9B8cGu+VLl5i7M4Nj/vhWdV6BmLAW6G0nQbXcofKCc q5etJOHoPtlTZMNe8E+s3tufuw== X-Google-Smtp-Source: AAOMgpc5KKKqfATpgSmUgKIDRihxDlFIr+6pXfTENmQBsJzsdBG/zi0DSq66tQkOJhwuQytZXhwkAQ== X-Received: by 2002:a17:902:3c5:: with SMTP id d63-v6mr11179170pld.163.1530894141977; Fri, 06 Jul 2018 09:22:21 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:0:1000:1501:38e4:86fe:ec0c:4007]) by smtp.gmail.com with ESMTPSA id e125-v6sm8926688pfe.52.2018.07.06.09.22.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jul 2018 09:22:21 -0700 (PDT) From: Douglas Anderson To: hminas@synopsys.com, gregkh@linuxfoundation.org Cc: Jerome Brunet , Zhangfei Gao , Stephen Warren , Bruno Herrera , Douglas Anderson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFT PATCH 4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms Date: Fri, 6 Jul 2018 09:21:54 -0700 Message-Id: <20180706162154.196345-5-dianders@chromium.org> X-Mailer: git-send-email 2.18.0.399.gad0ab374a1-goog In-Reply-To: <20180706162154.196345-1-dianders@chromium.org> References: <20180706162154.196345-1-dianders@chromium.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no reason to have the uframe scheduler off on dwc2. Running with uframe_sched = False is equivalent to saying "I don't want to run the correct code, I want to run the old and incorrect code". The uframe scheduler has been off on stm32f4x9_fsotg since commit e35b135055e2 ("usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)"). That commit is pretty recent, so it's unclear to me why the uframe scheduler was left off. Hopefully it's because someone copied it from other parameters and didn't think to try it? Presumably if everyone is good w/ the uframe_sched turned back on we can kill all the old and crufty non-uframe sched code. Signed-off-by: Douglas Anderson --- drivers/usb/dwc2/params.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 93380f7c32b4..7be35bcde713 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -131,7 +131,6 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg) p->max_packet_count = 256; p->phy_type = DWC2_PHY_TYPE_PARAM_FS; p->i2c_enable = false; - p->uframe_sched = false; p->activate_stm_fs_transceiver = true; }