From patchwork Thu Jul 26 20:07:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 10546405 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF0DC14E2 for ; Thu, 26 Jul 2018 20:08:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A60BA2BCA3 for ; Thu, 26 Jul 2018 20:08:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9A60C2BCAD; Thu, 26 Jul 2018 20:08:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 351412BCA3 for ; Thu, 26 Jul 2018 20:08:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731286AbeGZV0Z (ORCPT ); Thu, 26 Jul 2018 17:26:25 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40947 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730402AbeGZV0Z (ORCPT ); Thu, 26 Jul 2018 17:26:25 -0400 Received: by mail-pg1-f195.google.com with SMTP id x5-v6so1799928pgp.7 for ; Thu, 26 Jul 2018 13:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l/myg6m+9/E2E5usmaA3mgBuQgW1vnAMb6sfkOe5tok=; b=jYChSlM7RnMm2wPFHBUMCAw2dL4hsCluRiGF/p5szHUtz8pdiOYpM8xEXY0QvhCc2O u6GuZehq+9VJJZmuLU2ukUtoqqq0FhAFla52X5fVdjHVrFYf9fWmlRwFBKIZKaj3idC3 wybTMcBcZF7hqLY9wR/f01qaRV88AICE09YTM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l/myg6m+9/E2E5usmaA3mgBuQgW1vnAMb6sfkOe5tok=; b=AVDLgOeFhI7B5+hnwZe7vKY4xHtW+U7LrLuav5rFornHmNLPLsoukLpUcL2DmRBeeE fkqgOwT5SpinUMiDSryB7L1kYh76A8VpvCxceX3svLYgomScJnarr5rU2xk+KDpXLPWt N1lq3Vlc9/D1gRa1hE0MqivrYUCTQ9vemqm3w/O8K3BdPKwKFzebUIuTpyG6QLqAGiHP 3/kgjUgO6/FFOi/cZHVQC7qLmzrtC/Hy4+Rzu2ZnuHqebyrQSksj1aeVCEFb+URq1ltN aWshNBZf2p+WWtUatp8N4hCIcbMLfs9R2i2N7ebjvVO9E0nphvwLwLTsK1Md5Q72xj20 9L1A== X-Gm-Message-State: AOUpUlHwtoz2An49xh7Lh3/1VCAzzNFm565pY8hT4D5tT1bmwWsfgD9t KzCry/EPfoIMBC8bRBH/iIIzCw== X-Google-Smtp-Source: AAOMgpcD9dtJtKK85I4RVkl1vzkP+CHk3cdc63Iv+Dt0fV67dvsEw0HGXsF6uml0d/rpFrfcIJXFQw== X-Received: by 2002:a62:930c:: with SMTP id b12-v6mr3476478pfe.193.1532635680239; Thu, 26 Jul 2018 13:08:00 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:0:1000:1501:38e4:86fe:ec0c:4007]) by smtp.gmail.com with ESMTPSA id u11-v6sm5784169pfd.117.2018.07.26.13.07.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 13:07:59 -0700 (PDT) From: Douglas Anderson To: balbi@kernel.org, hminas@synopsys.com, gregkh@linuxfoundation.org Cc: stefan.wahren@i2se.com, grigor.tovmasyan@synopsys.com, Bruno Herrera , Zhangfei Gao , john.stultz@linaro.org, Stephen Warren , Jerome Brunet , Douglas Anderson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [REPOST PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Date: Thu, 26 Jul 2018 13:07:27 -0700 Message-Id: <20180726200730.18290-2-dianders@chromium.org> X-Mailer: git-send-email 2.18.0.345.g5c9ce644c3-goog In-Reply-To: <20180726200730.18290-1-dianders@chromium.org> References: <20180726200730.18290-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no reason to have the uframe scheduler off on dwc2. Running with uframe_sched = False is equivalent to saying "I don't want to run the correct code, I want to run the old and incorrect code". The uframe scheduler has been off on Broadcom since commit 58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835"). Since then there have been many many improvements, notably the commit 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe scheduler") Presumably if everyone is good w/ the uframe_sched turned back on we can kill all the old and crufty non-uframe sched code. Signed-off-by: Douglas Anderson Tested-by: Stefan Wahren Acked-by: Minas Harutyunyan --- drivers/usb/dwc2/params.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index af075d4da895..14b8742e62fa 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg) p->max_transfer_size = 65535; p->max_packet_count = 511; p->ahbcfg = 0x10; - p->uframe_sched = false; } static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)