| Message ID | 20181008103223.15362-1-kilobyte@angband.pl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86/defconfig: Enable CONFIG_USB_XHCI_HCD | expand |
On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote: > A spanking new machine I just got has all but one USB ports wired as 3.0. > Booting defconfig resulted in no keyboard or mouse, which was pretty > uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity. > As 'y' not 'm' -- recovering from initrd problems needs a keyboard. > > Signed-off-by: Adam Borowski <kilobyte@angband.pl> > --- > arch/x86/configs/x86_64_defconfig | 1 + > 1 file changed, 1 insertion(+) defconfig for x86 actually still works? That's amazing in itself :) > diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig > index e32fc1f274d8..ac9ae487cfeb 100644 > --- a/arch/x86/configs/x86_64_defconfig > +++ b/arch/x86/configs/x86_64_defconfig > @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y > CONFIG_USB=y > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > CONFIG_USB_MON=y > +CONFIG_USB_XHCI_HCD=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_EHCI_TT_NEWSCHED=y > CONFIG_USB_OHCI_HCD=y You can probably turn ehci and ohci off if you have xhci in the "default" system now. thanks, greg k-h
On Mon, 8 Oct 2018, Greg Kroah-Hartman wrote: > On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote: > > A spanking new machine I just got has all but one USB ports wired as 3.0. > > Booting defconfig resulted in no keyboard or mouse, which was pretty > > uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity. > > As 'y' not 'm' -- recovering from initrd problems needs a keyboard. > > > > Signed-off-by: Adam Borowski <kilobyte@angband.pl> > > --- > > arch/x86/configs/x86_64_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > defconfig for x86 actually still works? That's amazing in itself :) > > > diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig > > index e32fc1f274d8..ac9ae487cfeb 100644 > > --- a/arch/x86/configs/x86_64_defconfig > > +++ b/arch/x86/configs/x86_64_defconfig > > @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y > > CONFIG_USB=y > > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > > CONFIG_USB_MON=y > > +CONFIG_USB_XHCI_HCD=y > > CONFIG_USB_EHCI_HCD=y > > CONFIG_USB_EHCI_TT_NEWSCHED=y > > CONFIG_USB_OHCI_HCD=y > > You can probably turn ehci and ohci off if you have xhci in the > "default" system now. Heh. My office PC has both EHCI and xHCI controllers, but it uses xHCI _only_ for SuperSpeed devices, and only on some of the ports. Not a combination I have heard of anywhere else. Enabling xHCI without EHCI on that computer would be a bad idea. :-) Alan Stern
On 10/8/18 8:20 AM, Alan Stern wrote: > On Mon, 8 Oct 2018, Greg Kroah-Hartman wrote: > >> On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote: >>> A spanking new machine I just got has all but one USB ports wired as 3.0. >>> Booting defconfig resulted in no keyboard or mouse, which was pretty >>> uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity. >>> As 'y' not 'm' -- recovering from initrd problems needs a keyboard. >>> >>> Signed-off-by: Adam Borowski <kilobyte@angband.pl> >>> --- >>> arch/x86/configs/x86_64_defconfig | 1 + >>> 1 file changed, 1 insertion(+) >> >> defconfig for x86 actually still works? That's amazing in itself :) >> >>> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig >>> index e32fc1f274d8..ac9ae487cfeb 100644 >>> --- a/arch/x86/configs/x86_64_defconfig >>> +++ b/arch/x86/configs/x86_64_defconfig >>> @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y >>> CONFIG_USB=y >>> CONFIG_USB_ANNOUNCE_NEW_DEVICES=y >>> CONFIG_USB_MON=y >>> +CONFIG_USB_XHCI_HCD=y >>> CONFIG_USB_EHCI_HCD=y >>> CONFIG_USB_EHCI_TT_NEWSCHED=y >>> CONFIG_USB_OHCI_HCD=y >> >> You can probably turn ehci and ohci off if you have xhci in the >> "default" system now. > > Heh. My office PC has both EHCI and xHCI controllers, but it uses xHCI > _only_ for SuperSpeed devices, and only on some of the ports. Not a > combination I have heard of anywhere else. Enabling xHCI without EHCI > on that computer would be a bad idea. :-) Yeah, I have some mixed HCD usages as well.
On Mon, Oct 08, 2018 at 03:19:44PM +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote: > > A spanking new machine I just got has all but one USB ports wired as 3.0. > > Booting defconfig resulted in no keyboard or mouse, which was pretty > > uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity. > > As 'y' not 'm' -- recovering from initrd problems needs a keyboard. > > > > Signed-off-by: Adam Borowski <kilobyte@angband.pl> > > --- > > arch/x86/configs/x86_64_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > defconfig for x86 actually still works? That's amazing in itself :) IIRC Gentoo even suggests it in the install instructions (although I haven't looked at Gentoo in quite a while). Other distros have handcrafted approximations of allmodconfig. > > +CONFIG_USB_XHCI_HCD=y > > CONFIG_USB_EHCI_HCD=y > > CONFIG_USB_OHCI_HCD=y > > You can probably turn ehci and ohci off if you have xhci in the > "default" system now. Besides mixed wiring (as Alan and Randy mentioned), some machines without USB3 are still usable. I haven't upgraded my home machine in ages -- yet despite it being an ancient Phenom2 x6 it builds defconfig in 6m 13s while this fresh work box in 3m something. Defconfig is supposed to handle a wide range of common hardware, so keeping support for 2011 stuff would be wise. As for !x86, I see that defconfigs for non-fringe archs already enable XHCI. Meow!
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote: > > A spanking new machine I just got has all but one USB ports wired as 3.0. > > Booting defconfig resulted in no keyboard or mouse, which was pretty > > uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity. > > As 'y' not 'm' -- recovering from initrd problems needs a keyboard. > > > > Signed-off-by: Adam Borowski <kilobyte@angband.pl> > > --- > > arch/x86/configs/x86_64_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > defconfig for x86 actually still works? That's amazing in itself :) Many of my test machines are able to boot the x86 defconfig bzImage to a shell, so it's more like an "Ingo's minconfig". ;-) /me tries to look innocently but fails miserably > > diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig > > index e32fc1f274d8..ac9ae487cfeb 100644 > > --- a/arch/x86/configs/x86_64_defconfig > > +++ b/arch/x86/configs/x86_64_defconfig > > @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y > > CONFIG_USB=y > > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > > CONFIG_USB_MON=y > > +CONFIG_USB_XHCI_HCD=y > > CONFIG_USB_EHCI_HCD=y > > CONFIG_USB_EHCI_TT_NEWSCHED=y > > CONFIG_USB_OHCI_HCD=y > > You can probably turn ehci and ohci off if you have xhci in the > "default" system now. Also, could we please refresh this in the 32-bit defconfig as well. Other than that the patch looks good to me, no objections to adding convenience options for people who have actually booted the thing on reasonably common PC hardware. Thanks, Ingo
diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig index e32fc1f274d8..ac9ae487cfeb 100644 --- a/arch/x86/configs/x86_64_defconfig +++ b/arch/x86/configs/x86_64_defconfig @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y CONFIG_USB=y CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_MON=y +CONFIG_USB_XHCI_HCD=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_TT_NEWSCHED=y CONFIG_USB_OHCI_HCD=y
A spanking new machine I just got has all but one USB ports wired as 3.0. Booting defconfig resulted in no keyboard or mouse, which was pretty uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity. As 'y' not 'm' -- recovering from initrd problems needs a keyboard. Signed-off-by: Adam Borowski <kilobyte@angband.pl> --- arch/x86/configs/x86_64_defconfig | 1 + 1 file changed, 1 insertion(+)