| Message ID | 20181107204029.88466-1-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 408d3ba006af57380fa48858b39f72fde6405031 |
| Headers | show |
| Series | usb: dwc3: don't log probe deferrals; but do log other error codes | expand |
Hi, Missatge de Brian Norris <briannorris@chromium.org> del dia dc., 7 de nov. 2018 a les 21:42: > > It's not very useful to repeat a bunch of probe deferral errors. And > it's also not very useful to log "failed" without telling the error > code. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > drivers/usb/dwc3/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 88c80fcc39f5..1ef346ba6a02 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1482,7 +1482,8 @@ static int dwc3_probe(struct platform_device *pdev) > > ret = dwc3_core_init(dwc); > if (ret) { > - dev_err(dev, "failed to initialize core\n"); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "failed to initialize core: %d\n", ret); > goto err4; > } > > -- > 2.19.1.930.g4563a0d9d0-goog > fwiw this removes an annoying boot message that appears on every boot and also was confusing some people that thought that their usb didn't work. Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 88c80fcc39f5..1ef346ba6a02 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1482,7 +1482,8 @@ static int dwc3_probe(struct platform_device *pdev) ret = dwc3_core_init(dwc); if (ret) { - dev_err(dev, "failed to initialize core\n"); + if (ret != -EPROBE_DEFER) + dev_err(dev, "failed to initialize core: %d\n", ret); goto err4; }
It's not very useful to repeat a bunch of probe deferral errors. And it's also not very useful to log "failed" without telling the error code. Signed-off-by: Brian Norris <briannorris@chromium.org> --- drivers/usb/dwc3/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)