| Message ID | 20190108060426.11581-1-ran.wang_1@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] usb: kconfig: remove dependency FSL_SOC for ehci fsl driver | expand |
On Tue, 8 Jan 2019, Ran Wang wrote: > From: Rajesh Bhagat <rajesh.bhagat@nxp.com> > > CONFIG_USB_EHCI_FSL is not dependent on FSL_SOC, it can be built on > non-PPC platforms. > > Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com> > --- > drivers/usb/host/Kconfig | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index 16758b1..53cbc0c 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -179,8 +179,8 @@ config XPS_USB_HCD_XILINX > devices only. > > config USB_EHCI_FSL > - tristate "Support for Freescale PPC on-chip EHCI USB controller" > - depends on FSL_SOC > + tristate "Support for Freescale on-chip EHCI USB controller" > + depends on USB_EHCI_HCD This line is not needed. The entire entry lies within an "if USB_EHCI_HCD" block. Alan Stern > select USB_EHCI_ROOT_HUB_TT > ---help--- > Variation of ARC USB block used in some Freescale chips. >
Hi Alan, > -----Original Message----- > From: Alan Stern <stern@rowland.harvard.edu> > Sent: Wednesday, January 09, 2019 00:12 > To: Ran Wang <ran.wang_1@nxp.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; linux- > usb@vger.kernel.org; linux-kernel@vger.kernel.org; Rajesh Bhagat > <rajesh.bhagat@nxp.com> > Subject: Re: [PATCH 1/3] usb: kconfig: remove dependency FSL_SOC for ehci > fsl driver > > On Tue, 8 Jan 2019, Ran Wang wrote: > > > From: Rajesh Bhagat <rajesh.bhagat@nxp.com> > > > > CONFIG_USB_EHCI_FSL is not dependent on FSL_SOC, it can be built on > > non-PPC platforms. > > > > Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com> > > Signed-off-by: Ran Wang <ran.wang_1@nxp.com> > > --- > > drivers/usb/host/Kconfig | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index > > 16758b1..53cbc0c 100644 > > --- a/drivers/usb/host/Kconfig > > +++ b/drivers/usb/host/Kconfig > > @@ -179,8 +179,8 @@ config XPS_USB_HCD_XILINX > > devices only. > > > > config USB_EHCI_FSL > > - tristate "Support for Freescale PPC on-chip EHCI USB controller" > > - depends on FSL_SOC > > + tristate "Support for Freescale on-chip EHCI USB controller" > > + depends on USB_EHCI_HCD > > This line is not needed. The entire entry lies within an "if USB_EHCI_HCD" > block. Got it, will remove it in next version, thanks. Regards, Ran > Alan Stern > > > select USB_EHCI_ROOT_HUB_TT > > ---help--- > > Variation of ARC USB block used in some Freescale chips. > >
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 16758b1..53cbc0c 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -179,8 +179,8 @@ config XPS_USB_HCD_XILINX devices only. config USB_EHCI_FSL - tristate "Support for Freescale PPC on-chip EHCI USB controller" - depends on FSL_SOC + tristate "Support for Freescale on-chip EHCI USB controller" + depends on USB_EHCI_HCD select USB_EHCI_ROOT_HUB_TT ---help--- Variation of ARC USB block used in some Freescale chips.