| Message ID | 20190116111133.31326-1-philipp.puschmann@emlix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high | expand |
On Wed, 16 Jan 2019 12:11:32 +0100, Philipp Puschmann wrote: > The i.MX6q/dl USB controller may drive the usb power line directly, but the > polarity depends on the board. Reset state of the polarity is low-active so > add this property to allow it to be high-active. > > Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com> > --- > Changes in v3: add description > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring <robh@kernel.org>
> > The i.MX6q/dl USB controller may drive the usb power line directly, but the polarity > depends on the board. Reset state of the polarity is low-active so add this property > to allow it to be high-active. > As far as I know, most of i.mx USB controllers (except imx28/23, but they don't have non-core registers) work like this, and most of them are low active for PP default. Would you just use "i.mx" at both your code and your comment? Peter > Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com> > --- > Changes in v3: add description > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > index adae82385dd6..8696e3eff6e7 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > @@ -93,6 +93,7 @@ i.mx specific properties > - over-current-active-low: over current signal polarity is active low. > - over-current-active-high: over current signal polarity is active high. > It's recommended to specify the over current polarity. > +- power-active-high: power signal polarity is high active (only for > +imx6q/dl) > - external-vbus-divider: enables off-chip resistor divider for Vbus > > Example: > -- > 2.20.1
Hi Peter, Am 17.01.19 um 08:01 schrieb Peter Chen: > >> >> The i.MX6q/dl USB controller may drive the usb power line directly, but the polarity >> depends on the board. Reset state of the polarity is low-active so add this property >> to allow it to be high-active. >> > > As far as I know, most of i.mx USB controllers (except imx28/23, but they don't have non-core registers) > work like this, and most of them are low active for PP default. Would you just use "i.mx" at > both your code and your comment? Am i right that i have to add my code block to (nearly) all other version specific init functions then? Will do so in next days and then send a v4 of this patch. > > Peter > >> Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com> >> --- >> Changes in v3: add description >> --- >> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt >> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt >> index adae82385dd6..8696e3eff6e7 100644 >> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt >> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt >> @@ -93,6 +93,7 @@ i.mx specific properties >> - over-current-active-low: over current signal polarity is active low. >> - over-current-active-high: over current signal polarity is active high. >> It's recommended to specify the over current polarity. >> +- power-active-high: power signal polarity is high active (only for >> +imx6q/dl) >> - external-vbus-divider: enables off-chip resistor divider for Vbus >> >> Example: >> -- >> 2.20.1 >
> Am 17.01.19 um 08:01 schrieb Peter Chen: > > > >> > >> The i.MX6q/dl USB controller may drive the usb power line directly, > >> but the polarity depends on the board. Reset state of the polarity is > >> low-active so add this property to allow it to be high-active. > >> > > > > As far as I know, most of i.mx USB controllers (except imx28/23, but > > they don't have non-core registers) work like this, and most of them > > are low active for PP default. Would you just use "i.mx" at both your code and > your comment? > > Am i right that i have to add my code block to (nearly) all other version specific init > functions then? Besides your current patch, only usbmisc_imx7d_init is needed to add the same content. Peter > Will do so in next days and then send a v4 of this patch. > > > > Peter > > > >> Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com> > >> --- > >> Changes in v3: add description > >> --- > >> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > >> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > >> index adae82385dd6..8696e3eff6e7 100644 > >> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > >> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > >> @@ -93,6 +93,7 @@ i.mx specific properties > >> - over-current-active-low: over current signal polarity is active low. > >> - over-current-active-high: over current signal polarity is active high. > >> It's recommended to specify the over current polarity. > >> +- power-active-high: power signal polarity is high active (only for > >> +imx6q/dl) > >> - external-vbus-divider: enables off-chip resistor divider for Vbus > >> > >> Example: > >> -- > >> 2.20.1 > >
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt index adae82385dd6..8696e3eff6e7 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt @@ -93,6 +93,7 @@ i.mx specific properties - over-current-active-low: over current signal polarity is active low. - over-current-active-high: over current signal polarity is active high. It's recommended to specify the over current polarity. +- power-active-high: power signal polarity is high active (only for imx6q/dl) - external-vbus-divider: enables off-chip resistor divider for Vbus Example:
The i.MX6q/dl USB controller may drive the usb power line directly, but the polarity depends on the board. Reset state of the polarity is low-active so add this property to allow it to be high-active. Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com> --- Changes in v3: add description --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + 1 file changed, 1 insertion(+)