| Message ID | 20190117082350.16481-1-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 527c1e567ead03ec21f6707e79c166ce680f17f7 |
| Headers | show |
| Series | USB: serial: keyspan_usa: add proper SPDX lines for .h files | expand |
On Thu, Jan 17, 2019 at 09:23:46AM +0100, Greg Kroah-Hartman wrote: > The keyspan_usa??msg.h files are under a BSD-3 style license, so > properly label them as such with a SPDX line at the top of the file. > > Cc: Johan Hovold <johan@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Applied for -rc3. Thanks, Johan
On Thu, Jan 17, 2019 at 09:23:46AM +0100, Greg Kroah-Hartman wrote: > The keyspan_usa??msg.h files are under a BSD-3 style license, so > properly label them as such with a SPDX line at the top of the file. > > Cc: Johan Hovold <johan@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/usb/serial/keyspan_usa26msg.h | 1 + > drivers/usb/serial/keyspan_usa28msg.h | 1 + > drivers/usb/serial/keyspan_usa49msg.h | 1 + > drivers/usb/serial/keyspan_usa67msg.h | 1 + > drivers/usb/serial/keyspan_usa90msg.h | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/drivers/usb/serial/keyspan_usa26msg.h b/drivers/usb/serial/keyspan_usa26msg.h > index 09e21e84fc4e..a68f1fb25b8a 100644 > --- a/drivers/usb/serial/keyspan_usa26msg.h > +++ b/drivers/usb/serial/keyspan_usa26msg.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: BSD-3-Clause */ Actually, all but the keyspan_usa67msg.h appear to use a modified BSD-3-Clause with the second (binary-distribution) clause removed. I assume you're aware of this and that the BSD-3-Clause identifier is still applicable. Just thought I'd mention it. Johan
On Fri, Jan 18, 2019 at 12:09:16PM +0100, Johan Hovold wrote: > On Thu, Jan 17, 2019 at 09:23:46AM +0100, Greg Kroah-Hartman wrote: > > The keyspan_usa??msg.h files are under a BSD-3 style license, so > > properly label them as such with a SPDX line at the top of the file. > > > > Cc: Johan Hovold <johan@kernel.org> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/usb/serial/keyspan_usa26msg.h | 1 + > > drivers/usb/serial/keyspan_usa28msg.h | 1 + > > drivers/usb/serial/keyspan_usa49msg.h | 1 + > > drivers/usb/serial/keyspan_usa67msg.h | 1 + > > drivers/usb/serial/keyspan_usa90msg.h | 1 + > > 5 files changed, 5 insertions(+) > > > > diff --git a/drivers/usb/serial/keyspan_usa26msg.h b/drivers/usb/serial/keyspan_usa26msg.h > > index 09e21e84fc4e..a68f1fb25b8a 100644 > > --- a/drivers/usb/serial/keyspan_usa26msg.h > > +++ b/drivers/usb/serial/keyspan_usa26msg.h > > @@ -1,3 +1,4 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause */ > > Actually, all but the keyspan_usa67msg.h appear to use a modified > BSD-3-Clause with the second (binary-distribution) clause removed. > > I assume you're aware of this and that the BSD-3-Clause identifier is > still applicable. Just thought I'd mention it. Yeah, I saw that, it's kind of the 2-clause, but there are 3 clauses in it :) The intent is for it to be 3 clause from what I can tell and what I remember. The goal was to allow the BSDs to be able to use the header file in their kernels, and they did, so all was good. I don't think the company is around anymore, so I doubt it really matters. thanks, greg k-h
On Fri, Jan 18, 2019 at 01:12:00PM +0100, Greg Kroah-Hartman wrote: > On Fri, Jan 18, 2019 at 12:09:16PM +0100, Johan Hovold wrote: > > On Thu, Jan 17, 2019 at 09:23:46AM +0100, Greg Kroah-Hartman wrote: > > > The keyspan_usa??msg.h files are under a BSD-3 style license, so > > > properly label them as such with a SPDX line at the top of the file. > > > > > > Cc: Johan Hovold <johan@kernel.org> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > --- > > > drivers/usb/serial/keyspan_usa26msg.h | 1 + > > > drivers/usb/serial/keyspan_usa28msg.h | 1 + > > > drivers/usb/serial/keyspan_usa49msg.h | 1 + > > > drivers/usb/serial/keyspan_usa67msg.h | 1 + > > > drivers/usb/serial/keyspan_usa90msg.h | 1 + > > > 5 files changed, 5 insertions(+) > > > > > > diff --git a/drivers/usb/serial/keyspan_usa26msg.h b/drivers/usb/serial/keyspan_usa26msg.h > > > index 09e21e84fc4e..a68f1fb25b8a 100644 > > > --- a/drivers/usb/serial/keyspan_usa26msg.h > > > +++ b/drivers/usb/serial/keyspan_usa26msg.h > > > @@ -1,3 +1,4 @@ > > > +/* SPDX-License-Identifier: BSD-3-Clause */ > > > > Actually, all but the keyspan_usa67msg.h appear to use a modified > > BSD-3-Clause with the second (binary-distribution) clause removed. > > > > I assume you're aware of this and that the BSD-3-Clause identifier is > > still applicable. Just thought I'd mention it. > > Yeah, I saw that, it's kind of the 2-clause, but there are 3 clauses in > it :) > > The intent is for it to be 3 clause from what I can tell and what I > remember. The goal was to allow the BSDs to be able to use the header > file in their kernels, and they did, so all was good. I don't think the > company is around anymore, so I doubt it really matters. Good, thanks for confirming. Johan
diff --git a/drivers/usb/serial/keyspan_usa26msg.h b/drivers/usb/serial/keyspan_usa26msg.h index 09e21e84fc4e..a68f1fb25b8a 100644 --- a/drivers/usb/serial/keyspan_usa26msg.h +++ b/drivers/usb/serial/keyspan_usa26msg.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ /* usa26msg.h diff --git a/drivers/usb/serial/keyspan_usa28msg.h b/drivers/usb/serial/keyspan_usa28msg.h index dee454c4609a..a19f3fe5d98d 100644 --- a/drivers/usb/serial/keyspan_usa28msg.h +++ b/drivers/usb/serial/keyspan_usa28msg.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ /* usa28msg.h diff --git a/drivers/usb/serial/keyspan_usa49msg.h b/drivers/usb/serial/keyspan_usa49msg.h index 163b2dea2ec5..8c3970fdd868 100644 --- a/drivers/usb/serial/keyspan_usa49msg.h +++ b/drivers/usb/serial/keyspan_usa49msg.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ /* usa49msg.h diff --git a/drivers/usb/serial/keyspan_usa67msg.h b/drivers/usb/serial/keyspan_usa67msg.h index 20fa3e2f7187..dcf502fdbb44 100644 --- a/drivers/usb/serial/keyspan_usa67msg.h +++ b/drivers/usb/serial/keyspan_usa67msg.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ /* usa67msg.h diff --git a/drivers/usb/serial/keyspan_usa90msg.h b/drivers/usb/serial/keyspan_usa90msg.h index 86708ecd8735..c4ca0f631d20 100644 --- a/drivers/usb/serial/keyspan_usa90msg.h +++ b/drivers/usb/serial/keyspan_usa90msg.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: BSD-3-Clause */ /* usa90msg.h
The keyspan_usa??msg.h files are under a BSD-3 style license, so properly label them as such with a SPDX line at the top of the file. Cc: Johan Hovold <johan@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/usb/serial/keyspan_usa26msg.h | 1 + drivers/usb/serial/keyspan_usa28msg.h | 1 + drivers/usb/serial/keyspan_usa49msg.h | 1 + drivers/usb/serial/keyspan_usa67msg.h | 1 + drivers/usb/serial/keyspan_usa90msg.h | 1 + 5 files changed, 5 insertions(+)