From patchwork Wed Jan 30 07:28:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 10787783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 75E3B91E for ; Wed, 30 Jan 2019 07:28:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 58E1D2C603 for ; Wed, 30 Jan 2019 07:28:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4812E2C6E1; Wed, 30 Jan 2019 07:28:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C34422C603 for ; Wed, 30 Jan 2019 07:28:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729050AbfA3H2S (ORCPT ); Wed, 30 Jan 2019 02:28:18 -0500 Received: from mail-eopbgr40079.outbound.protection.outlook.com ([40.107.4.79]:11776 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725820AbfA3H2S (ORCPT ); Wed, 30 Jan 2019 02:28:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WZTC8By4oYu6SrZ17K6PSff/BaXzh/5jINbve3oRyvw=; b=QM6/CyMczSrGfKHtZrAzcMIUjPO0yEg0uaodipyVS2F/5Zpg/MMg2Ub44lrzn1IsX4W6wQee35H+f1u/KIyZeaLJg1aKJaDgciCiGBo+d5uiTJc8iNPm9rLEcQPSkIsPik6DbbTZXk+PoRooqWwYRQDUxpSyXE0kCiH2VKMimXc= Received: from VI1PR04MB5327.eurprd04.prod.outlook.com (20.177.52.16) by VI1PR04MB6063.eurprd04.prod.outlook.com (20.179.25.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.21; Wed, 30 Jan 2019 07:28:13 +0000 Received: from VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2]) by VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2%2]) with mapi id 15.20.1580.017; Wed, 30 Jan 2019 07:28:13 +0000 From: Peter Chen To: "balbi@kernel.org" CC: "linux-usb@vger.kernel.org" , dl-linux-imx , Peter Chen , "stable@vger.kernel.org" , Leo Li Subject: [PATCH 1/1] usb: phy: Kconfig: change FSL_USB2_OTG as tristate Thread-Topic: [PATCH 1/1] usb: phy: Kconfig: change FSL_USB2_OTG as tristate Thread-Index: AQHUuG1c9Y35TEE3ykqfanj02+mm7Q== Date: Wed, 30 Jan 2019 07:28:13 +0000 Message-ID: <20190130072546.1122-1-peter.chen@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.14.1 x-clientproxiedby: HK0PR01CA0058.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::22) To VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:60::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB6063;6:6ipetVKK4yhfSvUVZxoR4e0CNd5AUZUZ8s5AJbtnUwCaW1ej42OIXFDiPDq5M6tguV4xcdZMvsh0IlFYpoc/l0FcgaeI5KcIzIwiqEdbwm5tFj720s2F2zN759395Fs/8WB2YnFBTunt3ymwppQtYfZWAm4qsDenK4GXaP4pGIbJUVjZn+bpOipc2xZL3Td4lhA9QLNzmWAo09IUx+l3fSLJl2kIz4yXE/kHzDSx9s55R0FEgkGS/K1U/dT/X+xrqGs2ao5hwINy5EA4JIkBK8JGrJk26LTnsqiPXGljXXcFmsRvdQycjkwXva+RssJ49nBYAFOmHMbvcLx9jnJciW+vID5y3bDce8lg14s/Y7VUz+CZHOvxK9wNL08qrsKru+ZxqqhmGqlLCgWtakH2b39GlRAUqqXcyKKJAKZLhpucU4MvopuVBjkiXbvjyxvqlImySV3eZMqkdE9r77ML5A==;5:XG5oZaDE8c4h23Wxmt3IxyNfb1gmB8uxMwKMhZqxIBaUqz5JIkfmE+AML3R5SIzWVvF/KHXycPVRq4a9Jug6yJn63TbdAZ6SrcVR7a2clUWsznkLAsc7B329eyus/OZrvmAQWgE+pp/gppVQTvJLSfb1yk12jgWiTFFflfu3lNvwQ8Kqxch9wGAWAtNmC5Ll+x7+aLMgHnyygcUyvoeZPw==;7:blO79ZIKL6f+b2bM0R65KPAPGp9+4ZFBIhSv3qbSo62s2ppRtXBTpBCFQB84uR7ks+pBTRXJX8cAyZOlVA1FIylr1XNTraSKUh0D2aRBYwJ1jpgmQr6jNoX+PwVkplxmU1WM3YPTbv7BuwYDl842Lg== x-ms-office365-filtering-correlation-id: eb8ef919-d9e4-4e98-a5ff-08d686847e62 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB6063; x-ms-traffictypediagnostic: VI1PR04MB6063: x-microsoft-antispam-prvs: x-forefront-prvs: 0933E9FD8D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(376002)(346002)(366004)(136003)(39860400002)(199004)(189003)(476003)(486006)(50226002)(1730700003)(81156014)(8936002)(8676002)(97736004)(81166006)(256004)(14444005)(2616005)(68736007)(99286004)(305945005)(44832011)(386003)(66066001)(52116002)(25786009)(6506007)(26005)(186003)(54906003)(102836004)(7736002)(2906002)(71200400001)(4326008)(2351001)(6512007)(316002)(478600001)(6116002)(14454004)(3846002)(106356001)(71190400001)(36756003)(53936002)(86362001)(5640700003)(6436002)(2501003)(6486002)(1076003)(6916009)(105586002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB6063;H:VI1PR04MB5327.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 95kZg7kAlxmj5iziZRnwQQloI1bO19harARC7JpK10AX1ydSIJnxrOphOGku6swkkFsXD/5W6htzgolEqGImDq4tslPB0sOuhW7JAW7JMUnHTm/Ht1LiL9PuAdBT9/kMQluxmO5LXb24cSba8WNSanRxMuHK9DbN9YEKdMAim3/ud8+kVU/1P5+6wVrZEDyMBP1mTyslIEOVJ1JcLhopgQJWOPuzmqav/yXttNTNjVolr6Uvhsf72NTRmJQ39Wg1bVjZkbCnYdrlWU7YXnagVBmJL62CsbCSKFq0hb0YVoDDssjIkAcmtGGYzWlMzysdbXqLAPmuHx396vWsRfIPLwJcd4u1f22mKhuwRUL2AVIY/XOJKcsWcUUd4ZVuRRqP9R4YYlfCRXs5YeLX7mpScufibIGoLWSmdg2nLT6w0t8= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb8ef919-d9e4-4e98-a5ff-08d686847e62 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2019 07:28:10.5933 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6063 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It depends on USB_OTG_FSM, but USB_OTG_FSM can be module, so FSL_USB2_OTG should be tristate. It fixes below build warning: drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_ioctl': phy-fsl-usb.c:(.text+0x5e4): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_start_srp': phy-fsl-usb.c:(.text+0x680): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_set_host': phy-fsl-usb.c:(.text+0x800): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_start_hnp': phy-fsl-usb.c:(.text+0x88c): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `show_fsl_usb2_otg_state': phy-fsl-usb.c:(.text+0xa44): undefined reference to `usb_otg_state_string' drivers/usb/phy/phy-fsl-usb.o: In function `a_wait_enum': phy-fsl-usb.c:(.text+0x1718): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_set_peripheral': phy-fsl-usb.c:(.text+0x1f20): undefined reference to `usb_gadget_vbus_disconnect' phy-fsl-usb.c:(.text+0x1f40): undefined reference to `otg_statemachine' Cc: #v4.1+ Cc: Li Yang Reported-by: Mark Brown Signed-off-by: Peter Chen Acked-by: Li Yang --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index d7312eed6088..5444d2437475 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -20,7 +20,7 @@ config AB8500_USB in host mode, low speed. config FSL_USB2_OTG - bool "Freescale USB OTG Transceiver Driver" + tristate "Freescale USB OTG Transceiver Driver" depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM && PM depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y' select USB_PHY