From patchwork Wed Jan 30 14:48:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suwan Kim X-Patchwork-Id: 10788721 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2FAC2746 for ; Wed, 30 Jan 2019 14:48:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D6822F17A for ; Wed, 30 Jan 2019 14:48:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B9AF2F370; Wed, 30 Jan 2019 14:48:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BD8972F377 for ; Wed, 30 Jan 2019 14:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729000AbfA3Osf (ORCPT ); Wed, 30 Jan 2019 09:48:35 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:35256 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726915AbfA3Ose (ORCPT ); Wed, 30 Jan 2019 09:48:34 -0500 Received: by mail-pg1-f194.google.com with SMTP id s198so10425030pgs.2 for ; Wed, 30 Jan 2019 06:48:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NiGyAfyIRk1L8o9dUKDG6QG/LfRNTlXgnkfvyY+HmrM=; b=TRaQCDxk2K3/6Ggfu71div5abl10UWqXjwqL6A2SHiuoSrbAEAeyXCvM6gqzo7HtyE bVdE8cB0rUx5LfT0S7q8dd0FQJtgAr0lzYSvt3nLq78H3AH4ov8adVhPGlVXgjIyK3x4 lA7acyeGETu2ZnFb1/NckPx92IQxx7uUBAO4zsiWhsRFYX831qPVZEVjNYJGS71oO939 OLl9WSeyvz0udC5rOv3eD2dqosafYNWnfqXTGbdSwQ8jmdO4P7y9/An0pwU1mdGAAAQg jnCv+5pSHxYE0gsJEA3Qjn28fomHm5nhkKDQayZWKYye5Nc2cqH6FlYiEskeQ89kXOln npKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NiGyAfyIRk1L8o9dUKDG6QG/LfRNTlXgnkfvyY+HmrM=; b=stEuh9Z5MvtbdX9dcBao1D/O9Jd4XeaA2B55zkPpwokFxyPxSYBkx5c9a/501pZYmm wkLUGxtt1WbwXj0B5mF/M1fSMUawOCSOeaEJPeb9PIeLiJ4eu92K+rAPkPijnyUCcEXV PX16hXCSL4ny3SeySN03HEHNJWqnbcKzFZDd5G6mvJs3fWqYmQT8WZkhBI3bTzfWMfIw OIdUNmY8aI5iVN26/uh6sRhmKXfrTl+/USdc+k03YFsC5wbp/ONEMB+i926MPlhky4BR fSHKgs6g1OrZaFzYCYbDm0fzwqKsWBeCybLLZ1OttRQCevrMUGAwtab5Z2cJtILE8wHw MK5Q== X-Gm-Message-State: AJcUukfat/p1Ay7QmclvH2/KcfK0GN2hfIIpjRj31vOqZzf+WZiP7yeH U8ZVtM/3ToXdBnKKUluNaAo= X-Google-Smtp-Source: ALg8bN4Aag/aVXcBBoSj5fFr0idzFdX6kOxMRT8Cj+B10Ygc78wHjSW7tFPpVAGa1y9fB700NXjGfg== X-Received: by 2002:a63:304:: with SMTP id 4mr25464085pgd.99.1548859714281; Wed, 30 Jan 2019 06:48:34 -0800 (PST) Received: from localhost.localdomain ([125.142.23.13]) by smtp.googlemail.com with ESMTPSA id h74sm7300632pfd.35.2019.01.30.06.48.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 06:48:33 -0800 (PST) From: Suwan Kim To: gregkh@linuxfoundation.org, stern@rowland.harvard.edu Cc: linux-usb@vger.kernel.org, mathias.nyman@linux.intel.com Subject: [PATCH] usb: core: Move variable initialization to appropriate place Date: Wed, 30 Jan 2019 23:48:28 +0900 Message-Id: <20190130144828.28360-1-suwan.kim027@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It is better to initialize the variable 'cfgno' in the for loop than at the current place. Signed-off-by: Suwan Kim Acked-by: Alan Stern --- drivers/usb/core/config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c index 4a0945c04b4c..7bb6b1bd06c8 100644 --- a/drivers/usb/core/config.c +++ b/drivers/usb/core/config.c @@ -805,7 +805,6 @@ int usb_get_configuration(struct usb_device *dev) unsigned char *bigbuffer; struct usb_config_descriptor *desc; - cfgno = 0; if (ncfg > USB_MAXCONFIG) { dev_warn(ddev, "too many configurations: %d, " "using maximum allowed: %d\n", ncfg, USB_MAXCONFIG); @@ -831,7 +830,7 @@ int usb_get_configuration(struct usb_device *dev) if (!desc) goto err2; - for (; cfgno < ncfg; cfgno++) { + for (cfgno = 0; cfgno < ncfg; cfgno++) { /* We grab just the first descriptor so we know how long * the whole configuration is */ result = usb_get_descriptor(dev, USB_DT_CONFIG, cfgno,