| Message ID | 20190222192239.10974-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | bfb2ab8e7138fc484952a948275eb443e8b9a360 |
| Headers | show |
| Series | usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode | expand |
On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote: > Keep the orientation value when setting the mux to safe mode, this > fixes the orientation getting reset when switching alt-modes. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Should this be also a fix? > --- > drivers/usb/typec/mux/pi3usb30532.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c > index 64eb5983e17a..9294e85fd34b 100644 > --- a/drivers/usb/typec/mux/pi3usb30532.c > +++ b/drivers/usb/typec/mux/pi3usb30532.c > @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state) > > switch (state) { > case TYPEC_STATE_SAFE: > - new_conf = PI3USB30532_CONF_OPEN; > + new_conf = (new_conf & PI3USB30532_CONF_SWAP) | > + PI3USB30532_CONF_OPEN; > break; > case TYPEC_STATE_USB: > new_conf = (new_conf & PI3USB30532_CONF_SWAP) | > -- > 2.20.1 thanks,
Hi, On 25-02-19 16:50, Heikki Krogerus wrote: > On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote: >> Keep the orientation value when setting the mux to safe mode, this >> fixes the orientation getting reset when switching alt-modes. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > Should this be also a fix? This only comes into play when switching alt-modes, so more or less the same as with the displayport altmode fix: "There are no users if this yet, until we've agreement on the DT bindings and code merged for adding alt-modes to an usb-connector node, nothing will be using this code, so I see little use in adding a Cc: stable or some such." Regards, Hans > >> --- >> drivers/usb/typec/mux/pi3usb30532.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c >> index 64eb5983e17a..9294e85fd34b 100644 >> --- a/drivers/usb/typec/mux/pi3usb30532.c >> +++ b/drivers/usb/typec/mux/pi3usb30532.c >> @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state) >> >> switch (state) { >> case TYPEC_STATE_SAFE: >> - new_conf = PI3USB30532_CONF_OPEN; >> + new_conf = (new_conf & PI3USB30532_CONF_SWAP) | >> + PI3USB30532_CONF_OPEN; >> break; >> case TYPEC_STATE_USB: >> new_conf = (new_conf & PI3USB30532_CONF_SWAP) | >> -- >> 2.20.1 > > thanks, >
On Mon, Feb 25, 2019 at 07:52:10PM +0100, Hans de Goede wrote: > Hi, > > On 25-02-19 16:50, Heikki Krogerus wrote: > > On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote: > > > Keep the orientation value when setting the mux to safe mode, this > > > fixes the orientation getting reset when switching alt-modes. > > > > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > > > Should this be also a fix? > > This only comes into play when switching alt-modes, so more > or less the same as with the displayport altmode fix: > > "There are no users if this yet, until we've agreement > on the DT bindings and code merged for adding alt-modes > to an usb-connector node, nothing will be using this code, > so I see little use in adding a Cc: stable or some such." Agree, thanks,
On 2/22/19 11:22 AM, Hans de Goede wrote: > Keep the orientation value when setting the mux to safe mode, this > fixes the orientation getting reset when switching alt-modes. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/usb/typec/mux/pi3usb30532.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c > index 64eb5983e17a..9294e85fd34b 100644 > --- a/drivers/usb/typec/mux/pi3usb30532.c > +++ b/drivers/usb/typec/mux/pi3usb30532.c > @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state) > > switch (state) { > case TYPEC_STATE_SAFE: > - new_conf = PI3USB30532_CONF_OPEN; > + new_conf = (new_conf & PI3USB30532_CONF_SWAP) | > + PI3USB30532_CONF_OPEN; > break; > case TYPEC_STATE_USB: > new_conf = (new_conf & PI3USB30532_CONF_SWAP) | >
On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote: > Keep the orientation value when setting the mux to safe mode, this > fixes the orientation getting reset when switching alt-modes. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/mux/pi3usb30532.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c > index 64eb5983e17a..9294e85fd34b 100644 > --- a/drivers/usb/typec/mux/pi3usb30532.c > +++ b/drivers/usb/typec/mux/pi3usb30532.c > @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state) > > switch (state) { > case TYPEC_STATE_SAFE: > - new_conf = PI3USB30532_CONF_OPEN; > + new_conf = (new_conf & PI3USB30532_CONF_SWAP) | > + PI3USB30532_CONF_OPEN; > break; > case TYPEC_STATE_USB: > new_conf = (new_conf & PI3USB30532_CONF_SWAP) | > -- > 2.20.1 thanks,
On Fri, Mar 15, 2019 at 04:36:13PM +0200, Heikki Krogerus wrote: > On Fri, Feb 22, 2019 at 08:22:39PM +0100, Hans de Goede wrote: > > Keep the orientation value when setting the mux to safe mode, this > > fixes the orientation getting reset when switching alt-modes. > > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Also applied to my typec-next branch: https://github.com/krohei/linux/commit/4002f81b327b4537dead79ed6117dcb8065d2dca > > --- > > drivers/usb/typec/mux/pi3usb30532.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c > > index 64eb5983e17a..9294e85fd34b 100644 > > --- a/drivers/usb/typec/mux/pi3usb30532.c > > +++ b/drivers/usb/typec/mux/pi3usb30532.c > > @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state) > > > > switch (state) { > > case TYPEC_STATE_SAFE: > > - new_conf = PI3USB30532_CONF_OPEN; > > + new_conf = (new_conf & PI3USB30532_CONF_SWAP) | > > + PI3USB30532_CONF_OPEN; > > break; > > case TYPEC_STATE_USB: > > new_conf = (new_conf & PI3USB30532_CONF_SWAP) | > > -- > > 2.20.1 thanks,
diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c index 64eb5983e17a..9294e85fd34b 100644 --- a/drivers/usb/typec/mux/pi3usb30532.c +++ b/drivers/usb/typec/mux/pi3usb30532.c @@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state) switch (state) { case TYPEC_STATE_SAFE: - new_conf = PI3USB30532_CONF_OPEN; + new_conf = (new_conf & PI3USB30532_CONF_SWAP) | + PI3USB30532_CONF_OPEN; break; case TYPEC_STATE_USB: new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
Keep the orientation value when setting the mux to safe mode, this fixes the orientation getting reset when switching alt-modes. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/usb/typec/mux/pi3usb30532.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)