| Message ID | 20190319202658.17116-1-pakki001@umn.edu (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] usb: usb251xb: fix to avoid potential NULL pointer dereference | expand |
Hi, thanks for the updated patch. Please find my comments below. On 19/03/2019 21:26, Aditya Pakki wrote: > of_match_device in usb251xb_probe can fail and returns a NULL pointer. > The patch avoids a potential NULL pointer dereference in this scenario. > > -- This should be 3 dashes "---" ;-) > v1: Fix to avoid return in case of error, per Richard's suggestion. > Signed-off-by: Aditya Pakki <pakki001@umn.edu> This signed-off-by line should be in the commit message, not the "version history" which is not included in the commit. Apart from that (if you send a fixed v3) feel free to add Reviewed-by: Richard Leitner <richard.leitner@skidata.com> regards;Richard.L > --- > drivers/usb/misc/usb251xb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c > index 4d72b7d1d383..bbfdb7447d6f 100644 > --- a/drivers/usb/misc/usb251xb.c > +++ b/drivers/usb/misc/usb251xb.c > @@ -612,7 +612,7 @@ static int usb251xb_probe(struct usb251xb *hub) > dev); > int err; > > - if (np) { > + if (np && of_id) { > err = usb251xb_get_ofdata(hub, > (struct usb251xb_data *)of_id->data); > if (err) { >
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c index 4d72b7d1d383..bbfdb7447d6f 100644 --- a/drivers/usb/misc/usb251xb.c +++ b/drivers/usb/misc/usb251xb.c @@ -612,7 +612,7 @@ static int usb251xb_probe(struct usb251xb *hub) dev); int err; - if (np) { + if (np && of_id) { err = usb251xb_get_ofdata(hub, (struct usb251xb_data *)of_id->data); if (err) {
of_match_device in usb251xb_probe can fail and returns a NULL pointer. The patch avoids a potential NULL pointer dereference in this scenario. -- v1: Fix to avoid return in case of error, per Richard's suggestion. Signed-off-by: Aditya Pakki <pakki001@umn.edu> --- drivers/usb/misc/usb251xb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)