diff mbox series

[v3] usb: usb251xb: fix to avoid potential NULL pointer dereference

Message ID 20190320152711.28749-1-pakki001@umn.edu (mailing list archive)
State Mainlined
Commit 41f00e6e9e55546390031996b773e7f3c1d95928
Headers show
Series [v3] usb: usb251xb: fix to avoid potential NULL pointer dereference | expand

Commit Message

Aditya Pakki March 20, 2019, 3:27 p.m. UTC 
of_match_device in usb251xb_probe can fail and returns a NULL pointer.
The patch avoids a potential NULL pointer dereference in this scenario.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Richard Leitner <richard.leitner@skidata.com>

---
v2: Fix version changes below sign off
v1: avoid return in case of error, per Richard's suggestion.
---
 drivers/usb/misc/usb251xb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 4d72b7d1d383..bbfdb7447d6f 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -612,7 +612,7 @@  static int usb251xb_probe(struct usb251xb *hub)
 							   dev);
 	int err;
 
-	if (np) {
+	if (np && of_id) {
 		err = usb251xb_get_ofdata(hub,
 					  (struct usb251xb_data *)of_id->data);
 		if (err) {