| Message ID | 20190822135212.10195-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a684d8fd87182090ee96e34519ecdf009cef093a |
| Headers | show |
| Series | typec: tcpm: fix a typo in the comparison of pdo_max_voltage | expand |
On Thu, Aug 22, 2019 at 02:52:12PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There appears to be a typo in the comparison of pdo_max_voltage[i] > with the previous value, currently it is checking against the > array pdo_min_voltage rather than pdo_max_voltage. I believe this > is a typo. Fix this. > > Addresses-Coverity: ("Copy-paste error") > Fixes: 5007e1b5db73 ("typec: tcpm: Validate source and sink caps") > Signed-off-by: Colin Ian King <colin.king@canonical.com> I think you are correct. Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/usb/typec/tcpm/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 166b28562395..96562744101c 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -1439,7 +1439,7 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo, > else if ((pdo_min_voltage(pdo[i]) == > pdo_min_voltage(pdo[i - 1])) && > (pdo_max_voltage(pdo[i]) == > - pdo_min_voltage(pdo[i - 1]))) > + pdo_max_voltage(pdo[i - 1]))) > return PDO_ERR_DUPE_PDO; > break; > /* > -- > 2.20.1 >
On Thu, Aug 22, 2019 at 02:52:12PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There appears to be a typo in the comparison of pdo_max_voltage[i] > with the previous value, currently it is checking against the > array pdo_min_voltage rather than pdo_max_voltage. I believe this > is a typo. Fix this. > > Addresses-Coverity: ("Copy-paste error") > Fixes: 5007e1b5db73 ("typec: tcpm: Validate source and sink caps") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 166b28562395..96562744101c 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -1439,7 +1439,7 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo, > else if ((pdo_min_voltage(pdo[i]) == > pdo_min_voltage(pdo[i - 1])) && > (pdo_max_voltage(pdo[i]) == > - pdo_min_voltage(pdo[i - 1]))) > + pdo_max_voltage(pdo[i - 1]))) > return PDO_ERR_DUPE_PDO; > break; > /* > -- > 2.20.1 thanks,
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 166b28562395..96562744101c 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -1439,7 +1439,7 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo, else if ((pdo_min_voltage(pdo[i]) == pdo_min_voltage(pdo[i - 1])) && (pdo_max_voltage(pdo[i]) == - pdo_min_voltage(pdo[i - 1]))) + pdo_max_voltage(pdo[i - 1]))) return PDO_ERR_DUPE_PDO; break; /*