| Message ID | 20190830214409.49232-1-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | phy: cpcap-usb: Fix flakey host idling and enumerating of devices | expand |
diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c --- a/drivers/phy/motorola/phy-cpcap-usb.c +++ b/drivers/phy/motorola/phy-cpcap-usb.c @@ -274,12 +274,12 @@ static void cpcap_usb_detect(struct work_struct *work) return; } - /* Default to debug UART mode */ - error = cpcap_usb_set_uart_mode(ddata); + error = musb_mailbox(MUSB_VBUS_OFF); if (error) goto out_err; - error = musb_mailbox(MUSB_VBUS_OFF); + /* Default to debug UART mode */ + error = cpcap_usb_set_uart_mode(ddata); if (error) goto out_err;
We must let the USB host idle things properly before we switch to debug UART mode. Otherwise the USB host may never idle after disconnecting devices, and that causes the next enumeration to be flakey. This happens as the USB PHY mode gets disabled too early. Cc: Jacopo Mondi <jacopo@jmondi.org> Cc: Marcel Partap <mpartap@gmx.net> Cc: Merlijn Wajer <merlijn@wizzup.org> Cc: Michael Scott <hashcode0f@gmail.com> Cc: NeKit <nekit1000@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Sebastian Reichel <sre@kernel.org> Fixes: 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support") Signed-off-by: Tony Lindgren <tony@atomide.com> --- drivers/phy/motorola/phy-cpcap-usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)