| Message ID | 20190917144449.32739-5-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 905eccc6a509d2818e3dd1304c55dc5291b7ea88 |
| Headers | show |
| Series | Add simple-pm ops | expand |
On 17/09/2019 16:44, Marco Felsch wrote: > Currently the driver don't support pm_ops. These ops are not necessary > if the supply isn't switchable (always on). This assumptions seems to be > wrong because no one needs a powered hub during suspend-to-ram/disk. > > So adding simple_dev_pm_ops to be able to switch off the hub during > suspend and to restore the config after a resume operation. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> Hi, please feel free to add: Acked-by: Richard Leitner <richard.leitner@skidata.com> regards;Richard.L > --- > drivers/usb/misc/usb251xb.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c > index bc031d33f433..5bba19937da1 100644 > --- a/drivers/usb/misc/usb251xb.c > +++ b/drivers/usb/misc/usb251xb.c > @@ -701,6 +701,29 @@ static int usb251xb_i2c_probe(struct i2c_client *i2c, > return usb251xb_probe(hub); > } > > +static int __maybe_unused usb251xb_suspend(struct device *dev) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + struct usb251xb *hub = i2c_get_clientdata(client); > + > + return regulator_disable(hub->vdd); > +} > + > +static int __maybe_unused usb251xb_resume(struct device *dev) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + struct usb251xb *hub = i2c_get_clientdata(client); > + int err; > + > + err = regulator_enable(hub->vdd); > + if (err) > + return err; > + > + return usb251xb_connect(hub); > +} > + > +static SIMPLE_DEV_PM_OPS(usb251xb_pm_ops, usb251xb_suspend, usb251xb_resume); > + > static const struct i2c_device_id usb251xb_id[] = { > { "usb2512b", 0 }, > { "usb2512bi", 0 }, > @@ -718,6 +741,7 @@ static struct i2c_driver usb251xb_i2c_driver = { > .driver = { > .name = DRIVER_NAME, > .of_match_table = of_match_ptr(usb251xb_of_match), > + .pm = &usb251xb_pm_ops, > }, > .probe = usb251xb_i2c_probe, > .id_table = usb251xb_id, >
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c index bc031d33f433..5bba19937da1 100644 --- a/drivers/usb/misc/usb251xb.c +++ b/drivers/usb/misc/usb251xb.c @@ -701,6 +701,29 @@ static int usb251xb_i2c_probe(struct i2c_client *i2c, return usb251xb_probe(hub); } +static int __maybe_unused usb251xb_suspend(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct usb251xb *hub = i2c_get_clientdata(client); + + return regulator_disable(hub->vdd); +} + +static int __maybe_unused usb251xb_resume(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct usb251xb *hub = i2c_get_clientdata(client); + int err; + + err = regulator_enable(hub->vdd); + if (err) + return err; + + return usb251xb_connect(hub); +} + +static SIMPLE_DEV_PM_OPS(usb251xb_pm_ops, usb251xb_suspend, usb251xb_resume); + static const struct i2c_device_id usb251xb_id[] = { { "usb2512b", 0 }, { "usb2512bi", 0 }, @@ -718,6 +741,7 @@ static struct i2c_driver usb251xb_i2c_driver = { .driver = { .name = DRIVER_NAME, .of_match_table = of_match_ptr(usb251xb_of_match), + .pm = &usb251xb_pm_ops, }, .probe = usb251xb_i2c_probe, .id_table = usb251xb_id,
Currently the driver don't support pm_ops. These ops are not necessary if the supply isn't switchable (always on). This assumptions seems to be wrong because no one needs a powered hub during suspend-to-ram/disk. So adding simple_dev_pm_ops to be able to switch off the hub during suspend and to restore the config after a resume operation. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/usb/misc/usb251xb.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)