diff mbox series

[v2,1/6] usb: musb: dma: Correct parameter passed to IRQ handler

Message ID 20191025114710.13222-1-paul@crapouillou.net (mailing list archive)
State Superseded
Headers show
Series [v2,1/6] usb: musb: dma: Correct parameter passed to IRQ handler | expand

Commit Message

Paul Cercueil Oct. 25, 2019, 11:47 a.m. UTC 
The IRQ handler was passed a pointer to a struct dma_controller, but the
argument was then casted to a pointer to a struct musb_dma_controller.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
---

Notes:
    v2: Rebase on 4.5-rc4

 drivers/usb/musb/musbhsdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Cercueil Oct. 30, 2019, 11:23 a.m. UTC | #1 
Hi,


Le ven., oct. 25, 2019 at 13:47, Paul Cercueil <paul@crapouillou.net> a 
écrit :
> The IRQ handler was passed a pointer to a struct dma_controller, but 
> the
> argument was then casted to a pointer to a struct musb_dma_controller.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Tested-by: Artur Rojek <contact@artur-rojek.eu>
> ---
> 
> Notes:
>     v2: Rebase on 4.5-rc4

Typo in the changelog of this patch and the following ones: it was 
rebased on 5.4-rc4, obviously.


> 
>  drivers/usb/musb/musbhsdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/musbhsdma.c 
> b/drivers/usb/musb/musbhsdma.c
> index 5fc6825745f2..2d3751d885b4 100644
> --- a/drivers/usb/musb/musbhsdma.c
> +++ b/drivers/usb/musb/musbhsdma.c
> @@ -425,7 +425,7 @@ struct dma_controller 
> *musbhs_dma_controller_create(struct musb *musb,
>  	controller->controller.channel_abort = dma_channel_abort;
> 
>  	if (request_irq(irq, dma_controller_irq, 0,
> -			dev_name(musb->controller), &controller->controller)) {
> +			dev_name(musb->controller), controller)) {
>  		dev_err(dev, "request_irq %d failed!\n", irq);
>  		musb_dma_controller_destroy(&controller->controller);
> 
> --
> 2.23.0
>
diff mbox series

Patch

diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
index 5fc6825745f2..2d3751d885b4 100644
--- a/drivers/usb/musb/musbhsdma.c
+++ b/drivers/usb/musb/musbhsdma.c
@@ -425,7 +425,7 @@  struct dma_controller *musbhs_dma_controller_create(struct musb *musb,
 	controller->controller.channel_abort = dma_channel_abort;
 
 	if (request_irq(irq, dma_controller_irq, 0,
-			dev_name(musb->controller), &controller->controller)) {
+			dev_name(musb->controller), controller)) {
 		dev_err(dev, "request_irq %d failed!\n", irq);
 		musb_dma_controller_destroy(&controller->controller);