diff mbox series

USBIP: add config dependency for SGL_ALLOC

Message ID 20191112154939.21217-1-oneukum@suse.com (mailing list archive)
State Mainlined
Commit 1ec13abac58b6f24e32f0d3081ef4e7456e62ed8
Headers show
Series USBIP: add config dependency for SGL_ALLOC | expand

Commit Message

Oliver Neukum Nov. 12, 2019, 3:49 p.m. UTC
USBIP uses lib/scatterlist.h
Hence it needs to set CONFIG_SGL_ALLOC

Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
 drivers/usb/usbip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg KH Nov. 12, 2019, 4:11 p.m. UTC | #1
On Tue, Nov 12, 2019 at 04:49:39PM +0100, Oliver Neukum wrote:
> USBIP uses lib/scatterlist.h
> Hence it needs to set CONFIG_SGL_ALLOC
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
>  drivers/usb/usbip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/usbip/Kconfig b/drivers/usb/usbip/Kconfig
> index 2f86b28fa3da..7bbae7a08642 100644
> --- a/drivers/usb/usbip/Kconfig
> +++ b/drivers/usb/usbip/Kconfig
> @@ -4,6 +4,7 @@ config USBIP_CORE
>  	tristate "USB/IP support"
>  	depends on NET
>  	select USB_COMMON
> +	select SGL_ALLOC
>  	---help---
>  	  This enables pushing USB packets over IP to allow remote
>  	  machines direct access to USB devices. It provides the
> -- 
> 2.16.4
> 

Heh, I had to do this as part of the backport patch, and I was wondering
why this wasn't triggering in Linus's tree as well...

I'll go queue this up now, thanks!

greg k-h
Shuah Nov. 12, 2019, 4:56 p.m. UTC | #2
On 11/12/19 8:49 AM, Oliver Neukum wrote:
> USBIP uses lib/scatterlist.h
> Hence it needs to set CONFIG_SGL_ALLOC
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
>   drivers/usb/usbip/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/usbip/Kconfig b/drivers/usb/usbip/Kconfig
> index 2f86b28fa3da..7bbae7a08642 100644
> --- a/drivers/usb/usbip/Kconfig
> +++ b/drivers/usb/usbip/Kconfig
> @@ -4,6 +4,7 @@ config USBIP_CORE
>   	tristate "USB/IP support"
>   	depends on NET
>   	select USB_COMMON
> +	select SGL_ALLOC
>   	---help---
>   	  This enables pushing USB packets over IP to allow remote
>   	  machines direct access to USB devices. It provides the
> 

Thanks for catching this.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/drivers/usb/usbip/Kconfig b/drivers/usb/usbip/Kconfig
index 2f86b28fa3da..7bbae7a08642 100644
--- a/drivers/usb/usbip/Kconfig
+++ b/drivers/usb/usbip/Kconfig
@@ -4,6 +4,7 @@  config USBIP_CORE
 	tristate "USB/IP support"
 	depends on NET
 	select USB_COMMON
+	select SGL_ALLOC
 	---help---
 	  This enables pushing USB packets over IP to allow remote
 	  machines direct access to USB devices. It provides the