diff mbox series

usb: core: urb: fix URB structure initialization function

Message ID 20191127160355.GA27196@ingrassia.epigenesys.com (mailing list archive)
State Mainlined
Commit 1cd17f7f0def31e3695501c4f86cd3faf8489840
Headers show
Series usb: core: urb: fix URB structure initialization function | expand

Commit Message

Emiliano Ingrassia Nov. 27, 2019, 4:03 p.m. UTC 
Explicitly initialize URB structure urb_list field in usb_init_urb().
This field can be potentially accessed uninitialized and its
initialization is coherent with the usage of list_del_init() in
usb_hcd_unlink_urb_from_ep() and usb_giveback_urb_bh() and its
explicit initialization in usb_hcd_submit_urb() error path.

Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com>
---
 drivers/usb/core/urb.c | 1 +
 1 file changed, 1 insertion(+)

--
2.24.0
diff mbox series

Patch

diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index 0eab79f82ce4..da923ec17612 100644
--- a/drivers/usb/core/urb.c
+++ b/drivers/usb/core/urb.c
@@ -45,6 +45,7 @@  void usb_init_urb(struct urb *urb)
 	if (urb) {
 		memset(urb, 0, sizeof(*urb));
 		kref_init(&urb->kref);
+		INIT_LIST_HEAD(&urb->urb_list);
 		INIT_LIST_HEAD(&urb->anchor_list);
 	}
 }