| Message ID | 20191220070202.239870-1-lkundrak@v3.sk (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 92f983520cb82c407a091bbeabb505fc97419d3a |
| Headers | show |
| Series | USB: EHCI: ehci-mv: drop pxa_ehci_type and unused device IDs | expand |
On Fri, Dec 20, 2019 at 08:02:02AM +0100, Lubomir Rintel wrote:
> A trivial cleanup.
How is dropping device ids a "trivial cleanup"?
Please be more descriptive as to why you are making a change.
Also, you sent a number of patches here and I do not know what order
they should be applied in. Please resend them all as a numbered patch
series so that I have a clue what to do.
thanks,
greg k-h
On Fri, 2019-12-20 at 08:35 +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 20, 2019 at 08:02:02AM +0100, Lubomir Rintel wrote: > > A trivial cleanup. > > How is dropping device ids a "trivial cleanup"? > > Please be more descriptive as to why you are making a change. Thanks for the response. I'll post a v2 with a hopefully better description. > Also, you sent a number of patches here and I do not know what order > they should be applied in. Please resend them all as a numbered patch > series so that I have a clue what to do. I did that because the patches are completely independent of each other -- they don't conflict and don't need to be applied any particular order. Would you still prefer a numbered series? > > thanks, > > greg k-h Thank you Lubo
On Fri, Dec 20, 2019 at 09:55:07AM +0100, Lubomir Rintel wrote: > On Fri, 2019-12-20 at 08:35 +0100, Greg Kroah-Hartman wrote: > > On Fri, Dec 20, 2019 at 08:02:02AM +0100, Lubomir Rintel wrote: > > > A trivial cleanup. > > > > How is dropping device ids a "trivial cleanup"? > > > > Please be more descriptive as to why you are making a change. > > Thanks for the response. I'll post a v2 with a hopefully better > description. > > > Also, you sent a number of patches here and I do not know what order > > they should be applied in. Please resend them all as a numbered patch > > series so that I have a clue what to do. > > I did that because the patches are completely independent of each other > -- they don't conflict and don't need to be applied any particular > order. Would you still prefer a numbered series? A numbered series is always easier. thanks, greg k-h
diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index c8717f06cd8cb..91602e3492084 100644 --- a/drivers/usb/host/ehci-mv.c +++ b/drivers/usb/host/ehci-mv.c @@ -257,10 +257,8 @@ static int mv_ehci_remove(struct platform_device *pdev) MODULE_ALIAS("mv-ehci"); static const struct platform_device_id ehci_id_table[] = { - {"pxa-u2oehci", PXA_U2OEHCI}, - {"pxa-sph", PXA_SPH}, - {"mmp3-hsic", MMP3_HSIC}, - {"mmp3-fsic", MMP3_FSIC}, + {"pxa-u2oehci", 0}, + {"pxa-sph", 0}, {}, }; diff --git a/include/linux/platform_data/mv_usb.h b/include/linux/platform_data/mv_usb.h index 5376b6d799d5d..20d239c02bf3a 100644 --- a/include/linux/platform_data/mv_usb.h +++ b/include/linux/platform_data/mv_usb.h @@ -6,14 +6,6 @@ #ifndef __MV_PLATFORM_USB_H #define __MV_PLATFORM_USB_H -enum pxa_ehci_type { - EHCI_UNDEFINED = 0, - PXA_U2OEHCI, /* pxa 168, 9xx */ - PXA_SPH, /* pxa 168, 9xx SPH */ - MMP3_HSIC, /* mmp3 hsic */ - MMP3_FSIC, /* mmp3 fsic */ -}; - enum { MV_USB_MODE_OTG, MV_USB_MODE_HOST,
A trivial cleanup. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> --- drivers/usb/host/ehci-mv.c | 6 ++---- include/linux/platform_data/mv_usb.h | 8 -------- 2 files changed, 2 insertions(+), 12 deletions(-)