| Message ID | 20200312143038.11719-1-martin.kepplinger@puri.sm (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RFC] usb: dwc3: enable runtime PM for drd role switch / extcon | expand |
Hi, (for commit logs, please break your lines at 72 characters) Martin Kepplinger <martin.kepplinger@puri.sm> writes: > Note: runtime PM currently needs to be enabled ("auto") manually via > sysfs as its power/control is set to "on" by the driver. Right, that's on purpose > When runtime PM enabled, dwc3 currently doesn't resume when a cable is > connected. It only suspends after a cable is disconnected. > > When using an extcon driver (for a different chip on the board), dwc3 > can register a hook for that. (Still undocumented -> TODO?). > > Make sure, dwc3 is resumed when "set_mode" is being called by drd. > > this is only a question about what's missing to properly keep runtime > PM enabled for dwc3 and if my change makes any sense at all. It seems > to work fine for me... > > I'm glad about any hints on how to keep runtime PM enabled (at least when > having an extcon hook set up). You need to remember that what you write here is going to be placed in the commit log and will survive forever in the history of the project. Can you be a little bit more technical? For example, why did you change the asynchronous pm_runtime_put() to synchronous versions? Why was that necessary? Also, you're missing your Signed-off-by line. Please, read the documentation about how to write patches. > thanks, > martin > --- > drivers/usb/dwc3/core.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 1d85c42b9c67..201b712bd961 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -118,6 +118,9 @@ static void __dwc3_set_mode(struct work_struct *work) > unsigned long flags; > int ret; > > + pm_runtime_mark_last_busy(dwc->dev); > + pm_runtime_put_sync_autosuspend(dwc->dev); why synchronous? > + > if (dwc->dr_mode != USB_DR_MODE_OTG) > return; > > @@ -196,6 +199,8 @@ void dwc3_set_mode(struct dwc3 *dwc, u32 mode) > { > unsigned long flags; > > + pm_runtime_get_sync(dwc->dev); why get here and put on another function? > + > spin_lock_irqsave(&dwc->lock, flags); > dwc->desired_dr_role = mode; > spin_unlock_irqrestore(&dwc->lock, flags); > @@ -1552,7 +1557,7 @@ static int dwc3_probe(struct platform_device *pdev) > goto err5; > > dwc3_debugfs_init(dwc); > - pm_runtime_put(dev); > + pm_runtime_put_sync(dev); why the conversion to synchronous?
On 15.03.20 10:13, Felipe Balbi wrote: > Hi, > > (for commit logs, please break your lines at 72 characters) > > Martin Kepplinger <martin.kepplinger@puri.sm> writes: > >> Note: runtime PM currently needs to be enabled ("auto") manually via >> sysfs as its power/control is set to "on" by the driver. > > Right, that's on purpose > >> When runtime PM enabled, dwc3 currently doesn't resume when a cable is >> connected. It only suspends after a cable is disconnected. >> >> When using an extcon driver (for a different chip on the board), dwc3 >> can register a hook for that. (Still undocumented -> TODO?). >> >> Make sure, dwc3 is resumed when "set_mode" is being called by drd. >> >> this is only a question about what's missing to properly keep runtime >> PM enabled for dwc3 and if my change makes any sense at all. It seems >> to work fine for me... >> >> I'm glad about any hints on how to keep runtime PM enabled (at least when >> having an extcon hook set up). > > You need to remember that what you write here is going to be placed in > the commit log and will survive forever in the history of the > project. Can you be a little bit more technical? For example, why did > you change the asynchronous pm_runtime_put() to synchronous versions? > Why was that necessary?> > Also, you're missing your Signed-off-by line. Please, read the > documentation about how to write patches. I don't sign off on this change. It merely servers as a basis for the question I have: How to properly have continuous runtime PM in dwc3 (at least when having an extcon device connected) and is there any specific reason why this isn't yet implemented? > >> thanks, >> martin >> --- >> drivers/usb/dwc3/core.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >> index 1d85c42b9c67..201b712bd961 100644 >> --- a/drivers/usb/dwc3/core.c >> +++ b/drivers/usb/dwc3/core.c >> @@ -118,6 +118,9 @@ static void __dwc3_set_mode(struct work_struct *work) >> unsigned long flags; >> int ret; >> >> + pm_runtime_mark_last_busy(dwc->dev); >> + pm_runtime_put_sync_autosuspend(dwc->dev); > > why synchronous? Yes, that should not be necessary. please ignore switching to sync. > >> + >> if (dwc->dr_mode != USB_DR_MODE_OTG) >> return; >> >> @@ -196,6 +199,8 @@ void dwc3_set_mode(struct dwc3 *dwc, u32 mode) >> { >> unsigned long flags; >> >> + pm_runtime_get_sync(dwc->dev); > > why get here and put on another function? Actually, no real reason. If the general idea makes sense, it would be simpler (and also work) to have both in one function. > >> + >> spin_lock_irqsave(&dwc->lock, flags); >> dwc->desired_dr_role = mode; >> spin_unlock_irqrestore(&dwc->lock, flags); >> @@ -1552,7 +1557,7 @@ static int dwc3_probe(struct platform_device *pdev) >> goto err5; >> >> dwc3_debugfs_init(dwc); >> - pm_runtime_put(dev); >> + pm_runtime_put_sync(dev); > > why the conversion to synchronous? >
Hi, Martin Kepplinger <martin.kepplinger@puri.sm> writes: >> (for commit logs, please break your lines at 72 characters) >> >> Martin Kepplinger <martin.kepplinger@puri.sm> writes: >> >>> Note: runtime PM currently needs to be enabled ("auto") manually via >>> sysfs as its power/control is set to "on" by the driver. >> >> Right, that's on purpose >> >>> When runtime PM enabled, dwc3 currently doesn't resume when a cable is >>> connected. It only suspends after a cable is disconnected. >>> >>> When using an extcon driver (for a different chip on the board), dwc3 >>> can register a hook for that. (Still undocumented -> TODO?). >>> >>> Make sure, dwc3 is resumed when "set_mode" is being called by drd. >>> >>> this is only a question about what's missing to properly keep runtime >>> PM enabled for dwc3 and if my change makes any sense at all. It seems >>> to work fine for me... >>> >>> I'm glad about any hints on how to keep runtime PM enabled (at least when >>> having an extcon hook set up). >> >> You need to remember that what you write here is going to be placed in >> the commit log and will survive forever in the history of the >> project. Can you be a little bit more technical? For example, why did >> you change the asynchronous pm_runtime_put() to synchronous versions? >> Why was that necessary?> >> Also, you're missing your Signed-off-by line. Please, read the >> documentation about how to write patches. > > I don't sign off on this change. It merely servers as a basis for the > question I have: How to properly have continuous runtime PM in dwc3 (at > least when having an extcon device connected) and is there any specific > reason why this isn't yet implemented? Probably because nobody has spent the time to do it. If you have HW and time to implement this, by all means, go ahead. Just make sure to keep the current functionality: pm runtime should only be enabled by userspace.
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 1d85c42b9c67..201b712bd961 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -118,6 +118,9 @@ static void __dwc3_set_mode(struct work_struct *work) unsigned long flags; int ret; + pm_runtime_mark_last_busy(dwc->dev); + pm_runtime_put_sync_autosuspend(dwc->dev); + if (dwc->dr_mode != USB_DR_MODE_OTG) return; @@ -196,6 +199,8 @@ void dwc3_set_mode(struct dwc3 *dwc, u32 mode) { unsigned long flags; + pm_runtime_get_sync(dwc->dev); + spin_lock_irqsave(&dwc->lock, flags); dwc->desired_dr_role = mode; spin_unlock_irqrestore(&dwc->lock, flags); @@ -1552,7 +1557,7 @@ static int dwc3_probe(struct platform_device *pdev) goto err5; dwc3_debugfs_init(dwc); - pm_runtime_put(dev); + pm_runtime_put_sync(dev); return 0;
Note: runtime PM currently needs to be enabled ("auto") manually via sysfs as its power/control is set to "on" by the driver. When runtime PM enabled, dwc3 currently doesn't resume when a cable is connected. It only suspends after a cable is disconnected. When using an extcon driver (for a different chip on the board), dwc3 can register a hook for that. (Still undocumented -> TODO?). Make sure, dwc3 is resumed when "set_mode" is being called by drd. this is only a question about what's missing to properly keep runtime PM enabled for dwc3 and if my change makes any sense at all. It seems to work fine for me... I'm glad about any hints on how to keep runtime PM enabled (at least when having an extcon hook set up). thanks, martin --- drivers/usb/dwc3/core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)