| Message ID | 20200415141750.811-1-oneukum@suse.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 5963dec98dc52d52476390485f07a29c30c6a582 |
| Headers | show |
| Series | [1/2] UAS: no use logging any details in case of ENODEV | expand |
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 3670fda02c34..08503e3507bf 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -190,6 +190,9 @@ static void uas_log_cmd_state(struct scsi_cmnd *cmnd, const char *prefix, struct uas_cmd_info *ci = (void *)&cmnd->SCp; struct uas_cmd_info *cmdinfo = (void *)&cmnd->SCp; + if (status == -ENODEV) /* too late */ + return; + scmd_printk(KERN_INFO, cmnd, "%s %d uas-tag %d inflight:%s%s%s%s%s%s%s%s%s%s%s%s ", prefix, status, cmdinfo->uas_tag,
Once a device is gone, the internal state does not matter anymore. There is no need to spam the logs. Signed-off-by: Oliver Neukum <oneukum@suse.com> Fixes: 326349f824619 ("uas: add dead request list") --- drivers/usb/storage/uas.c | 3 +++ 1 file changed, 3 insertions(+)