| Message ID | 20200508142136.4232-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe() | expand |
On Fri, 8 May 2020, Tang Bin wrote: > Delete unused initialized value, because 'retval' will be assigined > by the function mv_ehci_enable(). And delete the extra blank lines. > > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- Acked-by: Alan Stern <stern@rowland.harvard.edu> > Changes from v1 > - fix the commit message. > --- > drivers/usb/host/ehci-mv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c > index bd4f6ef53..1c079953e 100644 > --- a/drivers/usb/host/ehci-mv.c > +++ b/drivers/usb/host/ehci-mv.c > @@ -108,7 +108,7 @@ static int mv_ehci_probe(struct platform_device *pdev) > struct ehci_hcd *ehci; > struct ehci_hcd_mv *ehci_mv; > struct resource *r; > - int retval = -ENODEV; > + int retval; > u32 offset; > > if (usb_disabled()) > @@ -142,8 +142,6 @@ static int mv_ehci_probe(struct platform_device *pdev) > goto err_put_hcd; > } > > - > - > r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > ehci_mv->base = devm_ioremap_resource(&pdev->dev, r); > if (IS_ERR(ehci_mv->base)) { >
diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index bd4f6ef53..1c079953e 100644 --- a/drivers/usb/host/ehci-mv.c +++ b/drivers/usb/host/ehci-mv.c @@ -108,7 +108,7 @@ static int mv_ehci_probe(struct platform_device *pdev) struct ehci_hcd *ehci; struct ehci_hcd_mv *ehci_mv; struct resource *r; - int retval = -ENODEV; + int retval; u32 offset; if (usb_disabled()) @@ -142,8 +142,6 @@ static int mv_ehci_probe(struct platform_device *pdev) goto err_put_hcd; } - - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); ehci_mv->base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(ehci_mv->base)) {