| Message ID | 20200520153617.610909-1-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | e9ccc35b86653cb15e9bffbe2cbef8781ea2c1dd |
| Headers | show |
| Series | [v3] usb: typec: Ensure USB_ROLE_SWITCH is set as a dependency for tps6598x | expand |
On Wed, May 20, 2020 at 04:36:17PM +0100, Bryan O'Donoghue wrote: > When I switched on USB role switching for the tps6598x I completely forgot > to add the Kconfig dependency. > > Ensure USB_ROLE_SWITCH is selected to prevent the typs6598x driver being > compiled in but the role-switch driver being compiled as a module, leading > to link error. > > Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index b4f2aac7ae8a..559dd06117e7 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -64,7 +64,8 @@ config TYPEC_HD3SS3220 > config TYPEC_TPS6598X > tristate "TI TPS6598x USB Power Delivery controller driver" > depends on I2C > - select REGMAP_I2C > + depends on REGMAP_I2C > + depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH > help > Say Y or M here if your system has TI TPS65982 or TPS65983 USB Power > Delivery controller. > -- > 2.25.1 thanks,
diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index b4f2aac7ae8a..559dd06117e7 100644 --- a/drivers/usb/typec/Kconfig +++ b/drivers/usb/typec/Kconfig @@ -64,7 +64,8 @@ config TYPEC_HD3SS3220 config TYPEC_TPS6598X tristate "TI TPS6598x USB Power Delivery controller driver" depends on I2C - select REGMAP_I2C + depends on REGMAP_I2C + depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH help Say Y or M here if your system has TI TPS65982 or TPS65983 USB Power Delivery controller.
When I switched on USB role switching for the tps6598x I completely forgot to add the Kconfig dependency. Ensure USB_ROLE_SWITCH is selected to prevent the typs6598x driver being compiled in but the role-switch driver being compiled as a module, leading to link error. Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- drivers/usb/typec/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)