| Message ID | 20200617180209.5636-7-wcheng@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce PMIC based USB type C detection | expand |
Hey Wesley, On Wed, Jun 17, 2020 at 11:02:09AM -0700, Wesley Cheng wrote: > Add the required DTS node for the USB VBUS output regulator, which is > available on PM8150B. This will provide the VBUS source to connected > peripherals. > > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 6 ++++++ > arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > index ec44a8bc2f84..b7274d9d7341 100644 > --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > @@ -22,6 +22,12 @@ power-on@800 { > status = "disabled"; > }; > > + qcom,dcdc@1100 { > + compatible = "qcom,pm8150b-vbus-reg"; > + status = "disabled"; > + reg = <0x1100>; > + }; > + > qcom,typec@1500 { > compatible = "qcom,pm8150b-usb-typec"; > status = "disabled"; Don't you also need a "usb_vbus-supply" property here under the Type-C node pointing to the phandle of the vbus reg? Jack > diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts > index 6c6325c3af59..3845d19893eb 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts > @@ -426,6 +426,13 @@ &usb_1 { > status = "okay"; > }; > > +&spmi_bus { > + pmic@2 { > + qcom,dcdc@1100 { > + status = "okay"; > + }; > +}; > + > &usb_1_dwc3 { > dr_mode = "peripheral"; > }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
On Wed 17 Jun 11:02 PDT 2020, Wesley Cheng wrote: > Add the required DTS node for the USB VBUS output regulator, which is > available on PM8150B. This will provide the VBUS source to connected > peripherals. > > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 6 ++++++ > arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > index ec44a8bc2f84..b7274d9d7341 100644 > --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > @@ -22,6 +22,12 @@ power-on@800 { > status = "disabled"; > }; > > + qcom,dcdc@1100 { You shouldn't use "qcom," in node names and whenever possible you should try to use generic node names. It would also be good to have a label on this, to allow the regulator to be referenced by a client. So please make this something like: pm8150b_vbus: regulator@1100 { > + compatible = "qcom,pm8150b-vbus-reg"; > + status = "disabled"; > + reg = <0x1100>; > + }; > + > qcom,typec@1500 { > compatible = "qcom,pm8150b-usb-typec"; > status = "disabled"; > diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts > index 6c6325c3af59..3845d19893eb 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts > @@ -426,6 +426,13 @@ &usb_1 { > status = "okay"; > }; > > +&spmi_bus { > + pmic@2 { > + qcom,dcdc@1100 { > + status = "okay"; > + }; > +}; And then you can enable &pm8150b_vbus here instead. Regards, Bjorn > + > &usb_1_dwc3 { > dr_mode = "peripheral"; > }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi index ec44a8bc2f84..b7274d9d7341 100644 --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi @@ -22,6 +22,12 @@ power-on@800 { status = "disabled"; }; + qcom,dcdc@1100 { + compatible = "qcom,pm8150b-vbus-reg"; + status = "disabled"; + reg = <0x1100>; + }; + qcom,typec@1500 { compatible = "qcom,pm8150b-usb-typec"; status = "disabled"; diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts index 6c6325c3af59..3845d19893eb 100644 --- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts @@ -426,6 +426,13 @@ &usb_1 { status = "okay"; }; +&spmi_bus { + pmic@2 { + qcom,dcdc@1100 { + status = "okay"; + }; +}; + &usb_1_dwc3 { dr_mode = "peripheral"; };
Add the required DTS node for the USB VBUS output regulator, which is available on PM8150B. This will provide the VBUS source to connected peripherals. Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> --- arch/arm64/boot/dts/qcom/pm8150b.dtsi | 6 ++++++ arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 7 +++++++ 2 files changed, 13 insertions(+)