usb: gadget: function: fix missing spinlock in f_uac1_legacy

Commit Message

Zhang, Qiang July 5, 2020, 1:59 a.m. UTC

From: Zhang Qiang <[e-mail]>

Signed-off-by: Zhang Qiang <[e-mail]>
---
 drivers/usb/gadget/function/f_uac1_legacy.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Greg Kroah-Hartman July 6, 2020, 7:40 a.m. UTC | #1

On Sun, Jul 05, 2020 at 09:59:41AM +0800, [e-mail] wrote:
> From: Zhang Qiang <[e-mail]>
> 
> Signed-off-by: Zhang Qiang <[e-mail]>

No changelog text?  I can't take patches like that, sorry.

greg k-h

Zhang, Qiang July 6, 2020, 8:01 a.m. UTC | #2

Sorry, I will add changelog and resend.

Zhang Qiang

Patch

diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c
index 349deae7cabd..e2d7f69128a0 100644
--- a/drivers/usb/gadget/function/f_uac1_legacy.c
+++ b/drivers/usb/gadget/function/f_uac1_legacy.c
@@ -336,7 +336,9 @@  static int f_audio_out_ep_complete(struct usb_ep *ep, struct usb_request *req)
 
 	/* Copy buffer is full, add it to the play_queue */
 	if (audio_buf_size - copy_buf->actual < req->actual) {
+		spin_lock_irq(&audio->lock);
 		list_add_tail(&copy_buf->list, &audio->play_queue);
+		spin_unlock_irq(&audio->lock);
 		schedule_work(&audio->playback_work);
 		copy_buf = f_audio_buffer_alloc(audio_buf_size);
 		if (IS_ERR(copy_buf))