diff mbox series

[v2] usb: gadget: function: fix missing spinlock in f_uac1_legacy

Message ID 20200705062435.1554-1-qiang.zhang@windriver.com (mailing list archive)
State Superseded
Headers show
Series [v2] usb: gadget: function: fix missing spinlock in f_uac1_legacy | expand

Commit Message

Zhang, Qiang July 5, 2020, 6:24 a.m. UTC 
From: Zhang Qiang <qiang.zhang@windriver.com>

Add a missing spinlock protection to the add operation of the play_queue
in "f_audio_out_ep_complete" function.

Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
---
 v1->v2:
 Add missing changelog.

 drivers/usb/gadget/function/f_uac1_legacy.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c
index 349deae7cabd..e2d7f69128a0 100644
--- a/drivers/usb/gadget/function/f_uac1_legacy.c
+++ b/drivers/usb/gadget/function/f_uac1_legacy.c
@@ -336,7 +336,9 @@  static int f_audio_out_ep_complete(struct usb_ep *ep, struct usb_request *req)
 
 	/* Copy buffer is full, add it to the play_queue */
 	if (audio_buf_size - copy_buf->actual < req->actual) {
+		spin_lock_irq(&audio->lock);
 		list_add_tail(&copy_buf->list, &audio->play_queue);
+		spin_unlock_irq(&audio->lock);
 		schedule_work(&audio->playback_work);
 		copy_buf = f_audio_buffer_alloc(audio_buf_size);
 		if (IS_ERR(copy_buf))