diff mbox series

[v2,4/9] usb: cdns3: drd: return IRQ_NONE explicitly.

Message ID 20200713100554.28530-5-pawell@cadence.com (mailing list archive)
State Mainlined
Commit 03cce68a828dba13b3715033e5133839820218c3
Headers show
Series usb: cdns3: Improvements for cdns3 DRD code | expand

Commit Message

Pawel Laszczak July 13, 2020, 10:05 a.m. UTC 
IRQ_NONE can be returned indirect.

Signed-off-by: Pawel Laszczak <pawell@cadence.com>
---
 drivers/usb/cdns3/drd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Chen July 22, 2020, 12:35 a.m. UTC | #1 
On 20-07-13 12:05:49, Pawel Laszczak wrote:
> IRQ_NONE can be returned indirect.
> 
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>

Reviewed-by: Peter Chen <peter.chen@nxp.com>

> ---
>  drivers/usb/cdns3/drd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
> index 6d2da504ad49..05a9f7d54c46 100644
> --- a/drivers/usb/cdns3/drd.c
> +++ b/drivers/usb/cdns3/drd.c
> @@ -279,12 +279,12 @@ static irqreturn_t cdns3_drd_irq(int irq, void *data)
>  	u32 reg;
>  
>  	if (cdns->dr_mode != USB_DR_MODE_OTG)
> -		return ret;
> +		return IRQ_NONE;
>  
>  	reg = readl(&cdns->otg_regs->ivect);
>  
>  	if (!reg)
> -		return ret;
> +		return IRQ_NONE;
>  
>  	if (reg & OTGIEN_ID_CHANGE_INT) {
>  		dev_dbg(cdns->dev, "OTG IRQ: new ID: %d\n",
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
index 6d2da504ad49..05a9f7d54c46 100644
--- a/drivers/usb/cdns3/drd.c
+++ b/drivers/usb/cdns3/drd.c
@@ -279,12 +279,12 @@  static irqreturn_t cdns3_drd_irq(int irq, void *data)
 	u32 reg;
 
 	if (cdns->dr_mode != USB_DR_MODE_OTG)
-		return ret;
+		return IRQ_NONE;
 
 	reg = readl(&cdns->otg_regs->ivect);
 
 	if (!reg)
-		return ret;
+		return IRQ_NONE;
 
 	if (reg & OTGIEN_ID_CHANGE_INT) {
 		dev_dbg(cdns->dev, "OTG IRQ: new ID: %d\n",