| Message ID | 20200812132034.14363-6-oneukum@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fix races in CDC-WDM | expand |
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index 6071c9044574..2dcf1fb16f2b 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c @@ -616,9 +616,6 @@ static int wdm_flush(struct file *file, fl_owner_t id) desc->werr = 0; spin_unlock_irq(&desc->iuspin); - if (rv < 0) - dev_err(&desc->intf->dev, "Error in flush path: %d\n", rv); - return usb_translate_errors(rv); }
After a disconnect intf->dev is not a valid pointer any longer as flush() uses it only for logging purposes logging is not worth it. Remove the dev_err() Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Signed-off-by: Oliver Neukum <oneukum@suse.com> --- drivers/usb/class/cdc-wdm.c | 3 --- 1 file changed, 3 deletions(-)