| Message ID | 20200910212512.16670-2-hamish.martin@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c4005a8f65edc55fb1700dfc5c1c3dc58be80209 |
| Headers | show |
| Series | [v2,1/2] usb: ohci: Default to per-port over-current protection | expand |
On Fri, Sep 11, 2020 at 09:25:12AM +1200, Hamish Martin wrote: > The 'distrust_firmware' module parameter dates from 2004 and the USB > subsystem is a lot more mature and reliable now than it was then. > Alter the default to false now. > > Suggested-by: Alan Stern <stern@rowland.harvard.edu> > Signed-off-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz> > --- > drivers/usb/host/ohci-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c > index 2845ea328a06..73e13e7c2b46 100644 > --- a/drivers/usb/host/ohci-hcd.c > +++ b/drivers/usb/host/ohci-hcd.c > @@ -102,7 +102,7 @@ static void io_watchdog_func(struct timer_list *t); > > > /* Some boards misreport power switching/overcurrent */ > -static bool distrust_firmware = true; > +static bool distrust_firmware; > module_param (distrust_firmware, bool, 0); > MODULE_PARM_DESC (distrust_firmware, > "true to distrust firmware power/overcurrent setup"); > -- > 2.28.0 Acked-by: Alan Stern <stern@rowland.harvard.edu>
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 2845ea328a06..73e13e7c2b46 100644 --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c @@ -102,7 +102,7 @@ static void io_watchdog_func(struct timer_list *t); /* Some boards misreport power switching/overcurrent */ -static bool distrust_firmware = true; +static bool distrust_firmware; module_param (distrust_firmware, bool, 0); MODULE_PARM_DESC (distrust_firmware, "true to distrust firmware power/overcurrent setup");
The 'distrust_firmware' module parameter dates from 2004 and the USB subsystem is a lot more mature and reliable now than it was then. Alter the default to false now. Suggested-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz> --- drivers/usb/host/ohci-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)