| Message ID | 20200922101329.14801-5-oneukum@suse.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFC,1/6] CDC-WDM: fix hangs in flush() in multithreaded cases | expand |
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index 1ca2c85a977d..5fb855404403 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c @@ -613,7 +613,10 @@ static int wdm_flush(struct file *file, fl_owner_t id) if (!rv) return -EIO; + spin_lock_irq(&desc->iuspin); rv = desc->werr; + desc->werr = 0; + spin_unlock_irq(&desc->iuspin); return usb_translate_errors(rv); }
In case a race was lost and multiple fds used, an error could be reported multiple times. To fix this a spinlock must be taken. Signed-off-by: Oliver Neukum <oneukum@suse.com> --- drivers/usb/class/cdc-wdm.c | 3 +++ 1 file changed, 3 insertions(+)