| Message ID | 20201009024937.11246-2-ryan_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enable USB host for AST2600 | expand |
On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > v2: > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > v1: > -Enable UHCI driver in aspeed_g5_defconfig. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> Why do you need this in a defconfig?
On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > v2: > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > v1: > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > Why do you need this in a defconfig? I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change. Ryan, I gave you my Reviewed-by for the last version of the patch. As you did not change the contents of this patch it is fine for you to leave my Reviewed-by on it. Cheers, Joel
On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote: > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > v2: > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > v1: > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > > > Why do you need this in a defconfig? > > I would prefer configurations that are being used to be present in the > defconfig so we can test it. I think this is a sensible change. Then it needs to be described in the changelog, otherwise we have no idea why this is happening :) thanks, greg k-h
> -----Original Message----- > From: Greg KH <greg@kroah.com> > Sent: Friday, October 9, 2020 1:47 PM > To: Joel Stanley <joel@jms.id.au> > Cc: Ryan Chen <ryan_chen@aspeedtech.com>; Andrew Jeffery > <andrew@aj.id.au>; Linux ARM <linux-arm-kernel@lists.infradead.org>; > linux-aspeed <linux-aspeed@lists.ozlabs.org>; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; linux-usb@vger.kernel.org; BMC-SW > <BMC-SW@aspeedtech.com>; Alan Stern <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig > > On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote: > > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > > v2: > > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > > v1: > > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > > > > > Why do you need this in a defconfig? > > > > I would prefer configurations that are being used to be present in the > > defconfig so we can test it. I think this is a sensible change. > > Then it needs to be described in the changelog, otherwise we have no idea > why this is happening :) > Ok, will send new version describe it.
> -----Original Message----- > From: Joel Stanley <joel@jms.id.au> > Sent: Friday, October 9, 2020 12:55 PM > To: Greg KH <greg@kroah.com> > Cc: Ryan Chen <ryan_chen@aspeedtech.com>; Andrew Jeffery > <andrew@aj.id.au>; Linux ARM <linux-arm-kernel@lists.infradead.org>; > linux-aspeed <linux-aspeed@lists.ozlabs.org>; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; linux-usb@vger.kernel.org; BMC-SW > <BMC-SW@aspeedtech.com>; Alan Stern <stern@rowland.harvard.edu> > Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig > > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote: > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > v2: > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > v1: > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > > > Why do you need this in a defconfig? > > I would prefer configurations that are being used to be present in the defconfig > so we can test it. I think this is a sensible change. > > Ryan, I gave you my Reviewed-by for the last version of the patch. As you did > not change the contents of this patch it is fine for you to leave my Reviewed-by > on it. Joel, thanks the review, so I need add Reviewed-by at each patch if someone have reviewed the previous patch, am I right?
diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig index 2bacd8c90f4b..7a6b0b79be9f 100644 --- a/arch/arm/configs/aspeed_g5_defconfig +++ b/arch/arm/configs/aspeed_g5_defconfig @@ -90,6 +90,8 @@ CONFIG_BLK_DEV_NBD=y CONFIG_MCTP_LPC=y CONFIG_EEPROM_AT24=y CONFIG_EEPROM_AT25=y +CONFIG_SCSI=y +CONFIG_BLK_DEV_SD=y CONFIG_MD=y CONFIG_BLK_DEV_DM=y CONFIG_DM_VERITY=y @@ -212,6 +214,8 @@ CONFIG_USB_DYNAMIC_MINORS=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_ROOT_HUB_TT=y CONFIG_USB_EHCI_HCD_PLATFORM=y +CONFIG_USB_UHCI_HCD=y +CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_USB_ASPEED_VHUB=y CONFIG_USB_CONFIGFS=y
v2: -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. v1: -Enable UHCI driver in aspeed_g5_defconfig. Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- arch/arm/configs/aspeed_g5_defconfig | 4 ++++ 1 file changed, 4 insertions(+)